[py] Adjust linting configuration to include /scripts #15702
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
This PR adjusts the linting configurations in
tox.inito include files in the/scriptsdirectory. This also fixes all linting errors discovered in those files.🔧 Implementation Notes
I ran into 2 weird issues:
blackformatter was unable to discover files in subdirectories if you include a parent directory, so I had to invokeblackon../scriptsseparatelyflake8andautoflakeare unable to process files in a parent directory, so I didn't change their settings to include../scripts🔄 Types of changes
PR Type
Enhancement
Description
Expanded linting to include
/scriptsdirectoryFixed linting errors in all
/scriptsPython filesUpdated
tox.inito run formatters and linters on/scriptsImproved code formatting and consistency in scripts
Changes walkthrough 📝
tox.ini
Expand linting configuration to cover `/scripts` directorypy/tox.ini
../scriptsdirectoryblack,isort, anddocformatterrun on/scriptspinned_browsers.py
Fix lint errors and reformat `pinned_browsers.py`scripts/pinned_browsers.py
selenium_manager.py
Fix lint errors and reformat `selenium_manager.py`scripts/selenium_manager.py
update_cdp.py
Fix lint errors and reformat `update_cdp.py`scripts/update_cdp.py
update_copyright.py
Fix lint errors and reformat `update_copyright.py`scripts/update_copyright.py