-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[ci] Clear warning from Grid UI component tests #15783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
🔗 Related Issues
💥 What does this PR do?
Clear few warning from component tests of Grid UI due to:
https://github.com/SeleniumHQ/selenium/actions/runs/15211726088/job/42787262347
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Bug fix, Tests
Description
Fix missing "key" prop warning in Overview's sort menu.
Add missing GraphQL session mocks to Overview tests.
Update VNC session test data and assertions for accuracy.
Enhance test coverage for error and empty states in Overview.
Changes walkthrough 📝
Overview.tsx
Add missing "key" prop and minor cleanup in Overview
javascript/grid-ui/src/screens/Overview/Overview.tsx
Node.test.tsx
Update Node VNC session tests and assertions
javascript/grid-ui/src/tests/components/Node.test.tsx
Overview.test.tsx
Add missing session mocks and enhance Overview tests
javascript/grid-ui/src/tests/components/Overview.test.tsx