[rb] Fix child process terminate method when a process is already terminated

[aguspe]

User description

🔗 Related Issues

Original issue #14689

💥 What does this PR do?

This PR adds a rescue for the terminate method on child process so it does not fail when there is nothing to terminate

🔄 Types of changes

• Bug fix (backwards compatible)

---

PR Type

Bug fix, Tests

---

Description

• Add error handling to terminate for missing processes

• Introduce unit test for terminate error handling

---

Changes walkthrough 📝

	Relevant files
Bug fix	child_process.rb Add error handling to terminate method for missing processes rb/lib/selenium/webdriver/common/child_process.rb Add rescue for Errno::ECHILD and Errno::ESRCH in terminate Prevent errors when terminating non-existent processes +2/-0
Tests	child_process_spec.rb Add test for terminate method error handling                          rb/spec/unit/selenium/webdriver/common/child_process_spec.rb Add unit test to verify terminate does not raise error on killed process Ensure robustness of process termination logic +38/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Handling The PR adds error handling for non-existent processes, but should verify if there are other potential errors that could occur during process termination that might need to be handled. rescue Errno::ECHILD, Errno::ESRCH # Process does not exist, nothing to terminate

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	✅ Add error handling Suggestion Impact: The commit implemented exactly what was suggested - adding error handling for Errno::ECHILD and Errno::ESRCH exceptions in the kill method with the same comment about process not existing code diff: + rescue Errno::ECHILD, Errno::ESRCH + # Process does not exist, nothing to kill Add error handling to the kill method similar to what was added to terminate. This ensures consistent behavior when trying to kill a process that no longer exists. rb/lib/selenium/webdriver/common/child_process.rb [129-131] def kill(pid) Process.kill(SIGKILL, pid) +rescue Errno::ECHILD, Errno::ESRCH + # Process does not exist, nothing to kill end [Suggestion processed] Suggestion importance[1-10]: 8 __ Why: Adding error handling for Errno::ECHILD and Errno::ESRCH in the kill method improves robustness and consistency, preventing unnecessary exceptions when attempting to kill a non-existent process, which is important for reliable process management.	Medium
Learned best practice	Add logging for exception handling The rescue block has a comment but should include logging to provide better visibility when this error condition occurs. This would help with debugging and monitoring process termination issues. rb/lib/selenium/webdriver/common/child_process.rb [123-127] def terminate(pid) Process.kill(SIGTERM, pid) rescue Errno::ECHILD, Errno::ESRCH - # Process does not exist, nothing to terminate + WebDriver.logger.debug("Process #{pid} does not exist, nothing to terminate", id: :process) end Apply / Chat Suggestion importance[1-10]: 6 __ Why: Relevant best practice - Add clear error messages and documentation for exception handling	Low
Update