Skip to content

[dotnet] [bidi] Add AcceptInsecureCerts and Proxy options when create new user context #15795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged

[dotnet] [bidi] Add AcceptInsecureCerts and Proxy options when create new user context #15795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dotnet/src/webdriver/BiDi/Modules/Browser/BrowserModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
// under the License.
// </copyright>

using System.Collections.Generic;
using System.Threading.Tasks;
using OpenQA.Selenium.BiDi.Communication;

Expand All @@ -32,7 +31,9 @@ public async Task CloseAsync(CloseOptions? options = null)

public async Task<UserContextInfo> CreateUserContextAsync(CreateUserContextOptions? options = null)
{
return await Broker.ExecuteCommandAsync<CreateUserContextCommand, UserContextInfo>(new CreateUserContextCommand(), options).ConfigureAwait(false);
var @params = new CreateUserContextCommandParameters(options?.AcceptInsecureCerts, options?.Proxy);

return await Broker.ExecuteCommandAsync<CreateUserContextCommand, UserContextInfo>(new CreateUserContextCommand(@params), options).ConfigureAwait(false);
}

public async Task<GetUserContextsResult> GetUserContextsAsync(GetUserContextsOptions? options = null)
Expand Down
13 changes: 10 additions & 3 deletions dotnet/src/webdriver/BiDi/Modules/Browser/CreateUserContextCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@

namespace OpenQA.Selenium.BiDi.Modules.Browser;

internal class CreateUserContextCommand()
: Command<CommandParameters, UserContextInfo>(CommandParameters.Empty, "browser.createUserContext");
internal class CreateUserContextCommand(CreateUserContextCommandParameters @params)
: Command<CreateUserContextCommandParameters, UserContextInfo>(@params, "browser.createUserContext");

public record CreateUserContextOptions : CommandOptions;
internal record CreateUserContextCommandParameters(bool? AcceptInsecureCerts, Session.ProxyConfiguration? Proxy) : CommandParameters;

public record CreateUserContextOptions : CommandOptions
{
public bool? AcceptInsecureCerts { get; set; }

public Session.ProxyConfiguration? Proxy { get; set; }
}
Loading