Skip to content

Conversation

@cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented May 27, 2025

User description

💥 What does this PR do?

This PR removes the silencing of stderr when calling bazel in ./scripts/format.sh. Without this, if you run the format script and don't have bazel installed, it just fails silently. This will make it more visible by not hiding the error.

🔄 Types of changes

  • build/tooling

PR Type

Enhancement


Description

  • Stop silencing stderr in format.sh Bazel calls

  • Improve error visibility when Bazel is missing


Changes walkthrough 📝

Relevant files
Enhancement
format.sh
Make Bazel errors visible in format.sh script                       

scripts/format.sh

  • Removed redirection of stderr to /dev/null for Bazel workspace info
  • Errors from Bazel are now visible to users
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-merge-pro
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label May 27, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented May 27, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    B-build Includes scripting, bazel and CI integrations Review effort 1/5

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants