- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8.6k
[dotnet] [bidi] Simplify modules namespace for end users (breaking change) #15820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| PR Reviewer Guide 🔍Here are some key observations to aid the review process: 
 | 
| PR Code Suggestions ✨No code suggestions found for the PR. | 
| Pretty big, but it really simplifies things. Thanks Nick. | 
User description
🔗 Related Issues
#15791
💥 What does this PR do?
Avoid
Modulesnamespace:Before:
After:
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement, Bug fix
Description
Flattened BiDi module namespaces for end users
Modulesnamespace from BiDi submodulesRefactored internal and test code to use new namespaces
Introduced a new
Key.csfile inInput(stub, commented)This is a breaking change for consumers of the BiDi .NET API
Changes walkthrough 📝
152 files
Remove `Modules` namespace from BiDi submodules and usagesMove BrowserModule to flattened namespaceMove ClientWindow to flattened namespaceMove ClientWindowInfo to flattened namespaceMove CloseCommand to flattened namespaceMove CreateUserContextCommand to flattened namespaceMove GetClientWindowsCommand to flattened namespaceMove GetUserContextsCommand to flattened namespaceMove RemoveUserContextCommand to flattened namespaceMove UserContext to flattened namespaceMove UserContextInfo to flattened namespaceMove ActivateCommand to flattened namespaceMove BrowsingContext to flattened namespaceMove BrowsingContextInfo to flattened namespaceMove BrowsingContextInputModule to flattened namespaceMove BrowsingContextLogModule to flattened namespaceMove BrowsingContextModule to flattened namespaceMove BrowsingContextNetworkModule to flattened namespaceMove BrowsingContextScriptModule to flattened namespaceMove BrowsingContextStorageModule to flattened namespaceMove CaptureScreenshotCommand to flattened namespaceMove CloseCommand to flattened namespaceMove CreateCommand to flattened namespaceMove GetTreeCommand to flattened namespaceMove HandleUserPromptCommand to flattened namespaceMove LocateNodesCommand to flattened namespaceMove Locator to flattened namespaceMove NavigateCommand to flattened namespaceMove Navigation to flattened namespaceMove NavigationInfo to flattened namespaceMove PrintCommand to flattened namespaceMove ReloadCommand to flattened namespaceMove SetViewportCommand to flattened namespaceMove TraverseHistoryCommand to flattened namespaceMove UserPromptClosedEventArgs to flattened namespaceMove UserPromptOpenedEventArgs to flattened namespaceUpdate logger and Subscription types for new namespacesUpdate EventHandler to use flattened BrowsingContextUpdate all JsonSerializable types to flattened namespacesUpdate using to flattened Browser namespaceUpdate using to flattened Browser namespaceUpdate BrowsingContextConverter to flattened namespaceUpdate using to flattened Script namespaceUpdate using to flattened Browser namespaceUpdate using to flattened Storage and Network namespacesUpdate using to flattened Script namespaceUpdate using to flattened Browser namespaceUpdate using to flattened Input namespaceUpdate using to flattened BrowsingContext and Script namespacesUpdate using to flattened Script namespaceUpdate using to flattened Input namespaceUpdate using to flattened Network namespaceUpdate using to flattened Script namespaceUpdate using to flattened BrowsingContext namespaceUpdate using to flattened Script namespaceUpdate LogEntryConverter to flattened Log namespaceUpdate using to flattened Script namespaceUpdate using to flattened Script namespaceUpdate using to flattened Script namespaceUpdate using to flattened BrowsingContext namespaceUpdate using to flattened Script namespaceUpdate using to flattened Script namespaceUpdate using to flattened Network namespaceUpdate SubscriptionConverter to flattened Session namespaceUpdate logger to use Internal.Logging.LogUpdate BrowsingContextEventArgs to flattened namespaceMove InputModule to flattened namespaceMove Origin to flattened namespaceMove PerformActionsCommand to flattened namespaceMove ReleaseActionsCommand to flattened namespaceMove SetFilesCommand to flattened namespaceMove SourceActions to flattened namespaceMove LogEntry to flattened namespaceMove LogModule to flattened namespaceMove Module base class to flattened namespaceMove AddInterceptCommand to flattened namespaceMove AuthChallenge to flattened namespaceMove AuthCredentials to flattened namespaceMove AuthRequiredEventArgs to flattened namespaceMove BaseParametersEventArgs to flattened namespaceMove BeforeRequestSentEventArgs to flattened namespaceMove BytesValue to flattened namespaceMove ContinueRequestCommand to flattened namespaceMove ContinueResponseCommand to flattened namespaceMove ContinueWithAuthCommand to flattened namespaceMove Cookie to flattened namespaceMove CookieHeader to flattened namespaceMove FailRequestCommand to flattened namespaceMove FetchErrorEventArgs to flattened namespaceMove FetchTimingInfo to flattened namespaceMove Header to flattened namespaceMove Initiator to flattened namespaceMove Intercept to flattened namespaceMove NetworkModule.HighLevel to flattened namespaceMove NetworkModule to flattened namespaceMove ProvideResponseCommand to flattened namespaceMove RemoveInterceptCommand to flattened namespaceMove Request to flattened namespaceMove RequestData to flattened namespaceMove ResponseCompletedEventArgs to flattened namespaceMove ResponseContent to flattened namespaceMove ResponseData to flattened namespaceMove ResponseStartedEventArgs to flattened namespaceMove SetCacheBehaviorCommand to flattened namespaceMove SetCookieHeader to flattened namespaceMove UrlPattern to flattened namespaceMove AddPreloadScriptCommand to flattened namespaceMove CallFunctionCommand to flattened namespaceMove Channel to flattened namespaceMove ChannelProperties to flattened namespaceMove DisownCommand to flattened namespaceMove EvaluateCommand to flattened namespaceMove GetRealmsCommand to flattened namespaceMove Handle to flattened namespaceMove IRemoteReference to flattened namespaceMove InternalId to flattened namespaceMove LocalValue to flattened namespaceMove MessageEventArgs to flattened namespaceMove NodeProperties to flattened namespaceMove PreloadScript to flattened namespaceMove Realm to flattened namespaceMove RealmDestroyedEventArgs to flattened namespaceMove RealmInfo to flattened namespaceMove RealmType to flattened namespaceMove RegExpValue to flattened namespaceMove RemoteValue to flattened namespaceMove RemovePreloadScriptCommand to flattened namespaceMove ResultOwnership to flattened namespaceMove ScriptModule to flattened namespaceMove SerializationOptions to flattened namespaceMove Source to flattened namespaceMove StackFrame to flattened namespaceMove StackTrace to flattened namespaceMove Target to flattened namespaceMove WindowProxyProperties to flattened namespaceMove CapabilitiesRequest to flattened namespaceMove CapabilityRequest to flattened namespaceMove EndCommand to flattened namespaceMove NewCommand to flattened namespaceMove ProxyConfiguration to flattened namespaceMove SessionModule to flattened namespaceMove StatusCommand to flattened namespaceMove SubscribeCommand to flattened namespaceMove Subscription to flattened namespaceMove UnsubscribeCommand to flattened namespaceMove UserPromptHandler to flattened namespaceMove DeleteCookiesCommand to flattened namespaceMove GetCookiesCommand to flattened namespaceMove PartitionKey to flattened namespaceMove SetCookieCommand to flattened namespaceMove StorageModule to flattened namespaceUpdate Subscription to use flattened Session namespace2 files
Add new (commented) Key.cs file in InputUpdate commented namespace to flattened Input15 files
Update BiDiFixture to use flattened BrowsingContextRemove old using, rely on flattened namespaceUpdate usings to flattened BrowsingContextUpdate using to flattened BrowsingContextUpdate LogTest to use flattened Log/Script typesUpdate usings to flattened BrowsingContextUpdate usings to flattened BrowsingContextRemove old using, rely on flattened namespaceUpdate usages to flattened BrowsingContextRemove old using, rely on flattened namespaceUpdate usages to flattened BrowsingContextRemove old using, rely on flattened namespaceUpdate usages to flattened BrowsingContext/Log typesUpdate usages to flattened BrowsingContextUpdate using to flattened Network namespace