- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8.6k
[dotnet] Remove unnecessary stylecop files #15824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| PR Reviewer Guide 🔍(Review updated until commit f084cc8)Here are some key observations to aid the review process: 
 | 
| PR Code Suggestions ✨No code suggestions found for the PR. | 
| Thank you, @nvborisenko for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. | 
| PR Code Suggestions ✨No code suggestions found for the PR. | 
User description
🔗 Related Issues
💥 What does this PR do?
In codebase we see some files related to C# code analysis. But these files are not used. So just remove it.
🔧 Implementation Notes
💡 Additional Considerations
Currently there is no tool to track code style. We have to introduce it via
.editorconfig. I already placed a placeholder here: https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/.editorconfigIn future I think we will take what .NET itself uses and make big restyling entire codebase.
🔄 Types of changes
PR Type
Other
Description
Remove unused StyleCop files from .NET projects
Clean up project files by eliminating references to StyleCop
Prepare codebase for future style tooling via .editorconfig
Changes walkthrough 📝
9 files
Remove StyleCop references from support projectRemove StyleCop references from Chrome tests projectRemove StyleCop references from Safari tests projectRemove StyleCop references from IE tests projectRemove StyleCop references from main WebDriver projectRemove StyleCop references from support tests projectRemove StyleCop references from remote tests projectRemove StyleCop references from Firefox tests projectRemove StyleCop references from common tests project10 files