Skip to content

[py][bidi]: add timestamp to HistoryUpdatedParams class #15892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

[py][bidi]: add timestamp to HistoryUpdatedParams class #15892

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c7fe4f
add `timestamp` to `HistoryUpdatedParams` class
navin772 Jun 12, 2025
ef3e2d4
Merge branch 'trunk' into add-timestamp-HistoryUpdatedParams
navin772 Jun 12, 2025
6a3580e
Merge branch 'trunk' into add-timestamp-HistoryUpdatedParams
navin772 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions py/selenium/webdriver/common/bidi/browsing_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,9 +335,11 @@ class HistoryUpdatedParams:
def __init__(
self,
context: str,
timestamp: int,
url: str,
):
self.context = context
self.timestamp = timestamp
self.url = url

@classmethod
Expand All @@ -356,12 +358,17 @@ def from_json(cls, json: dict) -> "HistoryUpdatedParams":
if context is None or not isinstance(context, str):
raise ValueError("context is required and must be a string")

timestamp = json.get("timestamp")
if timestamp is None or not isinstance(timestamp, int) or timestamp < 0:
raise ValueError("timestamp is required and must be a non-negative integer")

url = json.get("url")
if url is None or not isinstance(url, str):
raise ValueError("url is required and must be a string")

return cls(
context=context,
timestamp=timestamp,
url=url,
)

Expand Down
Loading