[java] Feat 14291/jspecify nullable annotation

[iampopovich]

User description

🔗 Related Issues

fixes #14291

💥 What does this PR do?

This pull request introduces the use of @Nullable annotations from the jspecify library to improve nullability handling across the Selenium Java codebase. It also updates the Bazel build files to include the jspecify dependency. The most important changes are grouped into updates to nullability handling and build file modifications.

Nullability Handling Enhancements:

• java/src/org/openqa/selenium/ie/InternetExplorerDriver.java: Added @Nullable annotations to the constructor parameters (InternetExplorerDriverService, InternetExplorerOptions, and ClientConfig) to explicitly indicate that these parameters can accept null values.
• java/src/org/openqa/selenium/remote/service/DriverService.java: Updated several methods (getDriverName, getDriverProperty, getDriverExecutable) to include @Nullable annotations, clarifying that their return values can be null.
• java/src/org/openqa/selenium/remote/service/DriverService.java: Imported the @Nullable annotation from the jspecify library.
• java/src/org/openqa/selenium/ie/InternetExplorerDriver.java: Imported the @Nullable annotation from the jspecify library.

Build File Modifications:

• java/src/org/openqa/selenium/ie/BUILD.bazel: Added the org_jspecify_jspecify dependency to the java_export target to integrate the jspecify library.
• java/src/org/openqa/selenium/remote/BUILD.bazel: Added the org.jspecify:jspecify artifact to the java_library target to enable usage of jspecify annotations.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

• Cleanup (formatting, renaming)

---

PR Type

Enhancement

---

Description

• Add JSpecify @Nullable annotations to improve nullability handling

• Update InternetExplorerDriver constructor parameters with nullable annotations

• Enhance DriverService methods with nullable return type annotations

• Update Bazel build files to include JSpecify dependency

---

Changes walkthrough 📝

	Relevant files
Enhancement	InternetExplorerDriver.java Add nullable annotations to constructor parameters              java/src/org/openqa/selenium/ie/InternetExplorerDriver.java Import JSpecify @Nullable annotation Add @Nullable annotations to constructor parameters (service, options, clientConfig) +4/-3      DriverService.java Add nullable annotations to method return types                    java/src/org/openqa/selenium/remote/service/DriverService.java Import JSpecify @Nullable annotation Add @Nullable annotations to method return types (getDriverName, getDriverProperty, getDriverExecutable) +4/-3
Dependencies	BUILD.bazel Add JSpecify dependency to build file                                        java/src/org/openqa/selenium/ie/BUILD.bazel Add JSpecify dependency to IE driver build configuration +1/-0      BUILD.bazel Add JSpecify dependency to build file                                        java/src/org/openqa/selenium/remote/BUILD.bazel Add JSpecify artifact dependency to remote package build configuration +1/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌ 1234 - Not compliant Non-compliant requirements: • Fix JavaScript execution in link's href attribute when using click() method • Ensure compatibility with Firefox 42.0 • Restore functionality that worked in version 2.47.1 but broke in 2.48.0/2.48.2 5678 - Not compliant Non-compliant requirements: • Fix ChromeDriver connection failure error on Ubuntu 16.04.4 • Resolve "ConnectFailure (Connection refused)" error for subsequent ChromeDriver instances • Ensure first ChromeDriver instance works without console errors • Support Chrome 65.0.3325.181 with ChromeDriver version 2.35

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Annotation Inconsistency The constructor parameters are annotated as @nullable but the method implementation immediately checks for null and creates default instances, which suggests these parameters should not be nullable or the annotation placement is incorrect. @Nullable InternetExplorerDriverService service, @Nullable InternetExplorerOptions options, @Nullable ClientConfig clientConfig) {

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Add missing null check validation Suggestion Impact: The suggestion was implemented but with a different coding style. Instead of using if-statements, the commit used ternary operators to handle null checks for all three parameters including clientConfig code diff: + options = options == null ? new InternetExplorerOptions() : options; + service = service == null ? InternetExplorerDriverService.createDefaultService() : service; + clientConfig = clientConfig == null ? ClientConfig.defaultConfig() : clientConfig; Add null check for clientConfig parameter to maintain consistency with other parameter validations. The method handles null options and service but doesn't validate clientConfig which could cause issues downstream. java/src/org/openqa/selenium/ie/InternetExplorerDriver.java [111-119] public InternetExplorerDriver( @Nullable InternetExplorerDriverService service, @Nullable InternetExplorerOptions options, @Nullable ClientConfig clientConfig) { if (options == null) { options = new InternetExplorerOptions(); } if (service == null) { service = InternetExplorerDriverService.createDefaultService(); + } + if (clientConfig == null) { + clientConfig = ClientConfig.defaultConfig(); + } [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that while the clientConfig parameter was annotated as @Nullable in the PR, the corresponding null-handling logic was missed. Adding this check prevents a potential NullPointerException and makes the constructor's behavior consistent with the other nullable parameters.	Medium
Update