Skip to content

[py] Return HTTP response reason when remote connection error occurs #15942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 26, 2025
Merged

[py] Return HTTP response reason when remote connection error occurs #15942

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
067858d
[py] Return HTTP response reason when remote connection error occurs
cgoldberg Jun 23, 2025
96a755a
[py] Remove f-string
cgoldberg Jun 23, 2025
2e03953
Merge branch 'trunk' into py-service-status-reason
cgoldberg Jun 23, 2025
fafc735
Merge branch 'SeleniumHQ:trunk' into py-service-status-reason
cgoldberg Jun 24, 2025
e6cbffd
Merge branch 'SeleniumHQ:trunk' into py-service-status-reason
cgoldberg Jun 25, 2025
7eb2778
Merge branch 'SeleniumHQ:trunk' into py-service-status-reason
cgoldberg Jun 25, 2025
2219a6f
Merge branch 'SeleniumHQ:trunk' into py-service-status-reason
cgoldberg Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions py/selenium/webdriver/remote/remote_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,10 +437,10 @@ def _request(self, method, url, body=None):
try:
if 300 <= statuscode < 304:
return self._request("GET", response.headers.get("location", None))
if 399 < statuscode <= 500:
if statuscode == 401:
return {"status": statuscode, "value": "Authorization Required"}
return {"status": statuscode, "value": str(statuscode) if not data else data.strip()}
if statuscode == 401:
return {"status": statuscode, "value": "Authorization Required"}
if statuscode >= 400:
return {"status": statuscode, "value": response.reason if not data else data.strip()}
content_type = []
if response.headers.get("Content-Type", None):
content_type = response.headers.get("Content-Type", None).split(";")
Expand Down
Loading