-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[build] Prepare for release of Selenium 4.34.0 #15958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
User description
Warning: Manually update the changelogs before merging
This PR:
PR Type
Other
Description
• Updates Chrome DevTools Protocol (CDP) support from version 135 to 138 across all language bindings (Java, .NET, Python, JavaScript, Ruby)
• Updates all package versions from nightly builds to stable 4.34.0 release across all bindings
• Updates Selenium Manager artifacts to new release version with updated SHA256 hashes
• Adds null safety check for
realmTypein Java BiDiRealmInfoclass to preventNullPointerException• Updates browser version references from 137/135 to 138 in test configurations
• Updates changelogs for all language bindings with new features and fixes for v4.34.0
• Updates bug report template and linting configurations
• Adds complete Bazel build configuration for CDP v138 support
Changes walkthrough 📝
14 files
v138Target.java
Update DevTools Target implementation from v135 to v138java/src/org/openqa/selenium/devtools/v138/v138Target.java
• Update package declaration from
v135tov138• Update all import
statements to reference
v138instead ofv135• Rename class from
v135Targettov138Target• Update all internal references to use
v138namespace
v138Network.java
Update DevTools Network implementation from v135 to v138java/src/org/openqa/selenium/devtools/v138/v138Network.java
• Update package declaration from
v135tov138• Update all import
statements to reference
v138instead ofv135• Rename class from
v135Networktov138Network• Update logger name and all internal
references to use
v138namespacev138Events.java
Update DevTools Events implementation from v135 to v138java/src/org/openqa/selenium/devtools/v138/v138Events.java
• Update package declaration from
v135tov138• Update all import
statements to reference
v138instead ofv135• Rename class from
v135Eventstov138Events• Update constructor and all internal
references to use
v138namespacev138Domains.java
Update DevTools Domains implementation from v135 to v138java/src/org/openqa/selenium/devtools/v138/v138Domains.java
• Update package declaration from
v135tov138• Rename class from
v135Domainstov138Domains• Update all field declarations and
constructor to use
v138class names• Update all method
implementations to instantiate
v138classesv138Javascript.java
Update DevTools Javascript implementation from v135 to v138java/src/org/openqa/selenium/devtools/v138/v138Javascript.java
• Update package declaration from
v135tov138• Update all import
statements to reference
v138instead ofv135• Rename class from
v135Javascripttov138Javascript• Update constructor to use
v138namespace
v138Log.java
Update DevTools Log implementation from v135 to v138java/src/org/openqa/selenium/devtools/v138/v138Log.java
• Update package declaration from
v135tov138• Update all import
statements to reference
v138instead ofv135• Rename class from
v135Logtov138Logv138CdpInfo.java
Update CDP Info implementation from v135 to v138java/src/org/openqa/selenium/devtools/v138/v138CdpInfo.java
• Update package declaration from
v135tov138• Rename class from
v135CdpInfotov138CdpInfo• Update constructor and CDP version number
from 135 to 138
• Update domains reference to use
v138DomainsV138Network.cs
Update .NET DevTools Network implementation from V135 to V138dotnet/src/webdriver/DevTools/v138/V138Network.cs
• Update file header comment from
V135Network.cstoV138Network.cs•
Update namespace from
V135toV138• Update using statements to
reference
V138instead ofV135• Rename class from
V135NetworktoV138Network• Update all internal references to use
V138namespaceV138Domains.cs
Update .NET DevTools Domains implementation from V135 to V138dotnet/src/webdriver/DevTools/v138/V138Domains.cs
• Update file header comment from
V135Domains.cstoV138Domains.cs•
Update namespace from
V135toV138• Rename class from
V135DomainstoV138Domains• Update DevToolsVersion property from 135 to 138
• Update
all property implementations to use
V138classesV138JavaScript.cs
Update .NET DevTools JavaScript implementation from V135 to V138dotnet/src/webdriver/DevTools/v138/V138JavaScript.cs
• Update file header comment from
V135JavaScript.cstoV138JavaScript.cs• Update namespace from
V135toV138• Update using
statements to reference
V138instead ofV135• Rename class from
V135JavaScripttoV138JavaScriptV138Target.cs
Update .NET DevTools Target implementation from V135 to V138dotnet/src/webdriver/DevTools/v138/V138Target.cs
• Update file header comment from
V135Target.cstoV138Target.cs•
Update namespace from
V135toV138• Update using statements to
reference
V138instead ofV135• Rename class from
V135TargettoV138TargetV138Log.cs
Update .NET DevTools Log implementation from V135 to V138dotnet/src/webdriver/DevTools/v138/V138Log.cs
• Update file header comment from
V135Log.cstoV138Log.cs• Update
namespace from
V135toV138• Update using statements to reference
V138instead ofV135• Rename class from
V135LogtoV138LogDevToolsDomains.cs
Update supported DevTools versions from 135 to 138dotnet/src/webdriver/DevTools/DevToolsDomains.cs
• Replace version 135 with 138 in
SupportedDevToolsVersionsarray•
Update
CreateDevToolsDomainmethod to instantiateV138Domainsinsteadof
V135Domainsselenium_manager.bzl
Update Selenium Manager artifacts to new release versioncommon/selenium_manager.bzl
• Update SHA256 hashes for all three selenium manager binaries (Linux,
macOS, Windows)
• Update download URLs from
selenium-manager-de70611to
selenium-manager-0ab9b6d1 files
RealmInfo.java
Add null safety check for realmType in RealmInfojava/src/org/openqa/selenium/bidi/script/RealmInfo.java
• Add null check for
realmTypebefore callingequals()method•
Prevents potential
NullPointerExceptionwhenrealmTypeis null9 files
DevToolsTargetTest.cs
Update DevTools test to use CDP version 138dotnet/test/common/DevTools/DevToolsTargetTest.cs
• Update
CurrentCdpVersionalias fromV137toV138• Update test ID
from 137 to 138
DevToolsTabsTest.cs
Update DevTools tabs test to use CDP version 138dotnet/test/common/DevTools/DevToolsTabsTest.cs
• Update
CurrentCdpVersionalias fromV137toV138DevToolsPerformanceTest.cs
Update DevTools performance test to use CDP version 138dotnet/test/common/DevTools/DevToolsPerformanceTest.cs
• Update
CurrentCdpVersionalias fromV137toV138DevToolsProfilerTest.cs
Update DevTools profiler test to use CDP version 138dotnet/test/common/DevTools/DevToolsProfilerTest.cs
• Update
CurrentCdpVersionalias fromV137toV138DevToolsConsoleTest.cs
Update DevTools console test to use CDP version 138dotnet/test/common/DevTools/DevToolsConsoleTest.cs
• Update
CurrentCdpVersionalias fromV137toV138DevToolsLogTest.cs
Update DevTools log test to use CDP version 138dotnet/test/common/DevTools/DevToolsLogTest.cs
• Update
CurrentCdpVersionalias fromV137toV138DevToolsNetworkTest.cs
Update DevTools network test to use CDP version 138dotnet/test/common/DevTools/DevToolsNetworkTest.cs
• Update
CurrentCdpVersionalias fromV137toV138DevToolsSecurityTest.cs
Update DevTools security test to use CDP version 138dotnet/test/common/DevTools/DevToolsSecurityTest.cs
• Update
CurrentCdpVersionalias fromV137toV138StableChannelChromeDriver.cs
Update Chrome browser version to 138 in test configurationdotnet/test/common/CustomDriverConfigs/StableChannelChromeDriver.cs
• Update
BrowserVersionfrom "137" to "138" inDefaultOptions12 files
__init__.py
Update Python WebDriver version to 4.34.0 releasepy/selenium/webdriver/init.py
• Update
__version__from "4.34.0.202505232017" to "4.34.0"__init__.py
Update Python Selenium version to 4.34.0 releasepy/selenium/init.py
• Update
__version__from "4.34.0.202505232017" to "4.34.0"BUILD.bazel
Add Bazel build configuration for CDP v138common/devtools/chromium/v138/BUILD.bazel
• Added complete Bazel build configuration for Chrome DevTools
Protocol v138
• Includes package visibility rules and genrules for
browser_protocol and js_protocol conversion
BUILD.bazel
Python version and CDP version updatespy/BUILD.bazel
• Updated SE_VERSION from nightly build to stable 4.34.0 release
•
Updated BROWSER_VERSIONS to replace v135 with v138 for Chrome CDP
support
.rubocop.yml
Ruby linting configuration updatesrb/.rubocop.yml
• Added exclusions for Naming/PredicateMethod rule for file_reaper.rb
and socket_poller.rb
BUILD.bazel
JavaScript version and CDP version updatesjavascript/selenium-webdriver/BUILD.bazel
• Updated VERSION from nightly build to stable 4.34.0 release
•
Updated BROWSER_VERSIONS to replace v135 with v138 for Chrome CDP
support
pyproject.toml
Python package version update to stable releasepy/pyproject.toml
• Updated Python package version from nightly build to stable 4.34.0
release
Cargo.toml
Rust selenium-manager version update to stable releaserust/Cargo.toml
• Updated Rust selenium-manager version from nightly to stable 0.4.34
release
package.json
JavaScript package version update to stable releasejavascript/selenium-webdriver/package.json
• Updated JavaScript package version from nightly build to stable
4.34.0 release
BUILD.bazel
Java CDP version update to v138java/src/org/openqa/selenium/devtools/v138/BUILD.bazel
• Updated cdp_version variable from v135 to v138 for Chrome DevTools
Protocol support
BUILD.bazel
Rust build version update to stable releaserust/BUILD.bazel
• Updated Rust binary version from nightly to stable 0.4.34 release
BUILD.bazel
Ruby CDP version update to v138rb/lib/selenium/devtools/BUILD.bazel
• Updated CDP_VERSIONS array to replace v135 with v138 for Chrome
DevTools Protocol support
7 files
CHANGELOG
Java changelog update for v4.34.0 releasejava/CHANGELOG
• Added changelog entries for version 4.34.0 with 23 new features and
fixes
• Includes CDP Chrome 138 support, deprecated class removals,
BiDi improvements, and Grid enhancements
js_protocol.pdl
Update CDP v138 protocol documentation for buildId fieldcommon/devtools/chromium/v138/js_protocol.pdl
• Updated buildId field documentation in Debugger domain
• Enhanced
description to include JavaScript debugId magic comment support
alongside Wasm modules
CHANGELOG
.NET changelog update for v4.34.0 releasedotnet/CHANGELOG
• Added changelog entries for .NET v4.34.0 with 14 new features and
fixes
• Includes CDP Chrome 138 support, BiDi improvements, and FTP
proxy deprecation
bug-report.yml
Update bug report template with latest version.github/ISSUE_TEMPLATE/bug-report.yml
• Updated latest Selenium version reference from 4.33 to 4.34 in bug
report template
CHANGES
Ruby changelog update for v4.34.0 releaserb/CHANGES
• Added Ruby changelog entries for v4.34.0 with CDP Chrome 138 support
• Includes child process fix and FTP proxy deprecation
CHANGES.md
JavaScript changelog update for v4.34.0 releasejavascript/selenium-webdriver/CHANGES.md
• Added JavaScript changelog entries for v4.34.0 with CDP Chrome 138
support
• Includes FTP proxy warning and Node.js version requirement
updates
CHANGELOG.md
Rust changelog update for v0.4.34 releaserust/CHANGELOG.md
• Added Rust changelog entries for v0.4.34 with Electron support and
safaridriver bug fixes
14 files