-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] Bump dependencies for building distribution wheel #15977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cgoldberg
merged 1 commit into
SeleniumHQ:trunk
from
cgoldberg:py-bump-wheel-dependencies
Jun 29, 2025
Merged
[py] Bump dependencies for building distribution wheel #15977
cgoldberg
merged 1 commit into
SeleniumHQ:trunk
from
cgoldberg:py-bump-wheel-dependencies
Jun 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This was referenced Jun 30, 2025
|
@cgoldberg Is it possible to make a Python hotfix release of this? I'd rather not wait 2 months for the next major release. |
|
@Houbein yes, 4.34.1 should be published soon |
3 tasks
sparrowt
reviewed
Aug 6, 2025
This was referenced Sep 12, 2025
This was referenced Sep 19, 2025
This was referenced Oct 1, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
This PR updates the Python dependencies listed in
py/BUILD.bazel(py_wheeltask). This is the dependency list used to build the Python wheel for distribution on PyPI.This was previously updated in
py/requirements.txtandpy/pyproject.toml(used for testing and local development), but it was not reflected in the wheel we are building.💡 Additional Considerations
Since this was not updated, Selenium
4.34package was released with the oldurllib3[socks]~=2.4.0dependency specifier listed. Anyone installing version4.34will get the oldurllib3package. Assuming this PR gets merged, the updated dependency specifier will be included in the next (4.35) release.🔄 Types of changes
PR Type
Other
Description
Update
urllib3[socks]dependency from~=2.4.0to~=2.5.0Update
certifidependency from>=2025.4.26to>=2025.6.15Synchronize wheel build dependencies with development requirements
Changes diagram
Changes walkthrough 📝
BUILD.bazel
Bump wheel build dependenciespy/BUILD.bazel
urllib3[socks]dependency from~=2.4.0to~=2.5.0certifidependency from>=2025.4.26to>=2025.6.15