Skip to content

Conversation

@navin772
Copy link
Member

@navin772 navin772 commented Jul 18, 2025

User description

🔗 Related Issues

💥 What does this PR do?

Updates selenium_manager.bzl to use latest build.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Other


Description

  • Update Selenium Manager artifacts to version 9d09338

  • Refresh SHA256 checksums for all platforms

  • Update download URLs for Linux, macOS, and Windows


Diagram Walkthrough

flowchart LR
  A["Old artifacts (0ab9b6d)"] --> B["Update process"]
  B --> C["New artifacts (9d09338)"]
  C --> D["Updated SHA256 checksums"]
  C --> E["Updated download URLs"]
Loading

File Walkthrough

Relevant files
Dependencies
selenium_manager.bzl
Update Selenium Manager artifact versions                               

common/selenium_manager.bzl

  • Updated artifact version from 0ab9b6d to 9d09338
  • Refreshed SHA256 checksums for Linux, macOS, and Windows
  • Updated download URLs for all three platforms
+6/-6     

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Jul 18, 2025
@qodo-merge-pro
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

1234 - Not compliant

Non-compliant requirements:

• Fix JavaScript execution in link's href attribute when click() is called
• Ensure compatibility with Firefox 42.0
• Restore functionality that worked in version 2.47.1 but broke in 2.48.0/2.48.2

5678 - Not compliant

Non-compliant requirements:

• Fix ChromeDriver ConnectFailure error on Ubuntu 16.04.4
• Resolve connection refused errors for subsequent ChromeDriver instances
• Ensure compatibility with Chrome 65.0.3325.181 and ChromeDriver 2.35

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Checksum integrity:
The PR updates SHA256 checksums for downloaded binaries from external sources. While checksums provide integrity verification, there's no indication that these new checksums have been independently verified against trusted sources. Malicious actors could potentially compromise the artifact repository and provide different binaries with matching but incorrect checksums.

⚡ Recommended focus areas for review

Checksum Verification

The SHA256 checksums have been updated for all three platforms but there's no verification that these checksums correspond to the correct artifacts or that the new version 9d09338 is properly tested and validated.

    sha256 = "f615ae2eea714a54e322f8945c7abb19e03e0f5d651b464bd5cd9e9ecf9e7c90",
    url = "https://github.com/SeleniumHQ/selenium_manager_artifacts/releases/download/selenium-manager-9d09338/selenium-manager-linux",
)

http_file(
    name = "download_sm_macos",
    executable = True,
    sha256 = "88fede46d14991930aab3176f6938ddb7549ab244f6d75a9745050d625274852",
    url = "https://github.com/SeleniumHQ/selenium_manager_artifacts/releases/download/selenium-manager-9d09338/selenium-manager-macos",
)

http_file(
    name = "download_sm_windows",
    executable = True,
    sha256 = "a7e8a7e0f561e7d8238f8aa884ef2dd6235884d3b0e97f25061747dbf4ec5037",
    url = "https://github.com/SeleniumHQ/selenium_manager_artifacts/releases/download/selenium-manager-9d09338/selenium-manager-windows.exe",

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@cgoldberg cgoldberg merged commit e8315e8 into SeleniumHQ:trunk Jul 18, 2025
13 of 15 checks passed
@navin772 navin772 deleted the update_se_manager_bzl branch July 18, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations Possible security concern Review effort 2/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants