Skip to content

[rb] Permit case insensitive sameSite attribute on cookie creation #16096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

[rb] Permit case insensitive sameSite attribute on cookie creation #16096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e7f95c
Capitalize sameSite attribute in cookie creation
luke-hill Jul 28, 2025
5b82b49
Merge branch 'trunk' into luke-hill-patch-1
aguspe Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rb/lib/selenium/webdriver/common/manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def add_cookie(opts = {})
opts[:secure] ||= false

same_site = opts.delete(:same_site)
opts[:sameSite] = same_site if same_site
opts[:sameSite] = same_site.capitalize if same_site

http_only = opts.delete(:http_only)
opts[:httpOnly] = http_only if http_only
Expand Down
Loading