Skip to content

[dotnet] Remove long awaited obsolete members #16121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2025
Merged

[dotnet] Remove long awaited obsolete members #16121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d309625
[dotnet] Remove long awaited obsolete members
nvborisenko Aug 2, 2025
50a4ecf
Return back interface method
nvborisenko Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions dotnet/src/webdriver/Chromium/ChromiumDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,19 +345,6 @@ public DevToolsSession GetDevToolsSession(DevToolsOptions options)
return this.devToolsSession;
}

/// <summary>
/// Creates a session to communicate with a browser using the Chromium Developer Tools debugging protocol.
/// </summary>
/// <param name="devToolsProtocolVersion">The version of the Chromium Developer Tools protocol to use. Defaults to autodetect the protocol version.</param>
/// <returns>The active session to use to communicate with the Chromium Developer Tools debugging protocol.</returns>
[Obsolete("Use GetDevToolsSession(DevToolsOptions options)")]
[RequiresUnreferencedCode(DevToolsSession.CDP_AOTIncompatibilityMessage)]
[RequiresDynamicCode(DevToolsSession.CDP_AOTIncompatibilityMessage)]
public DevToolsSession GetDevToolsSession(int devToolsProtocolVersion)
{
return GetDevToolsSession(new DevToolsOptions() { ProtocolVersion = devToolsProtocolVersion });
}

/// <summary>
/// Closes a DevTools session.
/// </summary>
Expand Down
11 changes: 0 additions & 11 deletions dotnet/src/webdriver/Chromium/ChromiumDriverService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,6 @@ protected ChromiumDriverService(string? executablePath, string? executableFileNa
/// </summary>
public ChromiumDriverLogLevel LogLevel { get; set; } = ChromiumDriverLogLevel.Default;

/// <summary>
/// <para>Gets or sets the comma-delimited list of IP addresses that are approved to connect to this instance of the Chrome driver.</para>
/// <para>A value of <see langword="null"/> or <see cref="string.Empty"/> means only the local loopback address can connect.</para>
/// </summary>
[Obsolete($"Use {nameof(AllowedIPAddresses)}")]
public string? WhitelistedIPAddresses
{
get => this.AllowedIPAddresses;
set => this.AllowedIPAddresses = value;
}

/// <summary>
/// <para>Gets or sets the comma-delimited list of IP addresses that are approved to connect to this instance of the Chrome driver.</para>
/// <para>A value of <see langword="null"/> or <see cref="string.Empty"/> means only the local loopback address can connect.</para>
Expand Down
7 changes: 0 additions & 7 deletions dotnet/src/webdriver/DevTools/DevToolsSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,6 @@ public class DevToolsSession : IDevToolsSession

private readonly static ILogger logger = Internal.Logging.Log.GetLogger<DevToolsSession>();

/// <summary>
/// Initializes a new instance of the DevToolsSession class, using the specified WebSocket endpoint.
/// </summary>
/// <param name="endpointAddress"></param>
[Obsolete("Use DevToolsSession(string endpointAddress, DevToolsOptions options)")]
public DevToolsSession(string endpointAddress) : this(endpointAddress, new DevToolsOptions()) { }

/// <summary>
/// Initializes a new instance of the DevToolsSession class, using the specified WebSocket endpoint and specified DevTools options.
/// </summary>
Expand Down
10 changes: 0 additions & 10 deletions dotnet/src/webdriver/DevTools/IDevTools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,6 @@ public interface IDevTools
[RequiresDynamicCode(DevToolsSession.CDP_AOTIncompatibilityMessage)]
DevToolsSession GetDevToolsSession(DevToolsOptions options);

/// <summary>
/// Creates a session to communicate with a browser using a specific version of the Developer Tools debugging protocol.
/// </summary>
/// <param name="protocolVersion">The specific version of the Developer Tools debugging protocol to use.</param>
/// <returns>The active session to use to communicate with the Developer Tools debugging protocol.</returns>
[Obsolete("Use GetDevToolsSession(DevToolsOptions options)")]
[RequiresUnreferencedCode(DevToolsSession.CDP_AOTIncompatibilityMessage)]
[RequiresDynamicCode(DevToolsSession.CDP_AOTIncompatibilityMessage)]
DevToolsSession GetDevToolsSession(int protocolVersion);

/// <summary>
/// Closes a DevTools session
/// </summary>
Expand Down
10 changes: 0 additions & 10 deletions dotnet/src/webdriver/Edge/EdgeDriverService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,6 @@ protected override DriverOptions GetDefaultDriverOptions()
return new EdgeOptions();
}

/// <summary>
/// Gets or sets a value indicating whether the service should use verbose logging.
/// </summary>
[Obsolete("Use EnableVerboseLogging")]
public bool UseVerboseLogging
{
get => this.EnableVerboseLogging;
set => this.EnableVerboseLogging = value;
}

/// <summary>
/// Creates a default instance of the EdgeDriverService.
/// </summary>
Expand Down
10 changes: 0 additions & 10 deletions dotnet/src/webdriver/Firefox/FirefoxOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,6 @@ public FirefoxOptions()
/// </summary>
public override string? BinaryLocation { get; set; }

/// <summary>
/// Gets or sets the path and file name of the Firefox browser executable.
/// </summary>
[Obsolete("Use BinaryLocation property instead of BrowserExecutableLocation. This one will be removed soon.")]
public string? BrowserExecutableLocation
{
get => this.BinaryLocation;
set => this.BinaryLocation = value;
}

/// <summary>
/// Gets or sets the logging level of the Firefox driver.
/// </summary>
Expand Down
7 changes: 0 additions & 7 deletions dotnet/src/webdriver/Interactions/ActionSequence.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,6 @@ public ActionSequence(InputDevice device, int initialSize)
/// </summary>
public int Count => this.interactions.Count;

/// <summary>
/// Gets the input device for this Action sequence.
/// </summary>
[Obsolete("This property has been renamed to InputDevice and will be removed in a future version")]
[CLSCompliant(false)]
public InputDevice inputDevice => InputDevice;

/// <summary>
/// Gets the input device for this Action sequence.
/// </summary>
Expand Down
28 changes: 0 additions & 28 deletions dotnet/src/webdriver/Internal/Logging/ConsoleLogHandler.cs
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions dotnet/src/webdriver/Remote/RemoteWebDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,19 +496,6 @@ public DevToolsSession GetDevToolsSession(DevToolsOptions options)
return this.devToolsSession;
}

/// <summary>
/// Creates a session to communicate with a browser using a specific version of the Developer Tools debugging protocol.
/// </summary>
/// <param name="protocolVersion">The specific version of the Developer Tools debugging protocol to use.</param>
/// <returns>The active session to use to communicate with the Developer Tools debugging protocol.</returns>
[Obsolete("Use GetDevToolsSession(DevToolsOptions options)")]
[RequiresUnreferencedCode(DevToolsSession.CDP_AOTIncompatibilityMessage)]
[RequiresDynamicCode(DevToolsSession.CDP_AOTIncompatibilityMessage)]
public DevToolsSession GetDevToolsSession(int protocolVersion)
{
return GetDevToolsSession(new DevToolsOptions() { ProtocolVersion = protocolVersion });
}

/// <summary>
/// Retrieves the downloadable files.
/// </summary>
Expand Down
11 changes: 0 additions & 11 deletions dotnet/src/webdriver/UserAgent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,13 @@
// under the License.
// </copyright>

using System;

namespace OpenQA.Selenium.DevTools;

/// <summary>
/// Represents a user agent string.
/// </summary>
public class UserAgent
{
/// <summary>
/// Initializes a new instance of the <see cref="UserAgent"/> type.
/// </summary>
[Obsolete("Use the constructor which sets the userAgentString")]
public UserAgent()
{
UserAgentString = null!;
}

/// <summary>
/// Initializes a new instance of the <see cref="UserAgent"/> type.
/// </summary>
Expand Down
Loading