Skip to content

[py]: enable chrome beta tests for CI-RBE #16125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025
+47 −2
Merged

[py]: enable chrome beta tests for CI-RBE #16125

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d1d627
enable chrome beta
navin772 Aug 4, 2025
a14d518
skip `devtools_tests.py` for chrome beta
navin772 Aug 4, 2025
81dbbd9
Merge branch 'trunk' into py-add-chrome-beta
navin772 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions py/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,8 @@ BIDI_TESTS = glob(["test/selenium/webdriver/common/**/*bidi*_tests.py"])
"test/selenium/webdriver/common/**/*.py",
"test/selenium/webdriver/support/**/*.py",
],
exclude = BIDI_TESTS + ["test/selenium/webdriver/common/print_pdf_tests.py"],
exclude = BIDI_TESTS + ["test/selenium/webdriver/common/print_pdf_tests.py"] +
(["test/selenium/webdriver/common/devtools_tests.py"] if browser == "chrome-beta" else []),
),
args = [
"--instafail",
Expand All @@ -467,7 +468,8 @@ BIDI_TESTS = glob(["test/selenium/webdriver/common/**/*bidi*_tests.py"])
"test/selenium/webdriver/common/**/*.py",
"test/selenium/webdriver/support/**/*.py",
],
exclude = ["test/selenium/webdriver/common/print_pdf_tests.py"],
exclude = ["test/selenium/webdriver/common/print_pdf_tests.py"] +
(["test/selenium/webdriver/common/devtools_tests.py"] if browser == "chrome-beta" else []),
),
args = [
"--instafail",
Expand Down Expand Up @@ -534,6 +536,29 @@ py_test_suite(
] + TEST_DEPS,
)

py_test_suite(
name = "test-chrome-beta",
size = "large",
srcs = glob(
[
"test/selenium/webdriver/chrome/**/*.py",
],
),
args = [
"--instafail",
] + BROWSERS["chrome-beta"]["args"],
data = BROWSERS["chrome-beta"]["data"],
env_inherit = ["DISPLAY"],
tags = [
"no-sandbox",
] + BROWSERS["chrome-beta"]["tags"],
deps = [
":init-tree",
":selenium",
":webserver",
] + TEST_DEPS,
)

py_test_suite(
name = "test-edge",
size = "large",
Expand Down
20 changes: 20 additions & 0 deletions py/private/browsers.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
load(
"//common:browsers.bzl",
"COMMON_TAGS",
"chrome_beta_data",
"chrome_data",
"edge_data",
"firefox_data",
Expand All @@ -27,6 +28,20 @@ chrome_args = select({
"//conditions:default": [],
}) + headless_args

chrome_beta_args = select({
"@selenium//common:use_pinned_linux_chrome": [
"--driver-binary=$(location @linux_beta_chromedriver//:chromedriver)",
"--browser-binary=$(location @linux_beta_chrome//:chrome-linux64/chrome)",
"--browser-args=--disable-dev-shm-usage",
"--browser-args=--no-sandbox",
],
"@selenium//common:use_pinned_macos_chrome": [
"--driver-binary=$(location @mac_beta_chromedriver//:chromedriver)",
"--browser-binary=$(location @mac_beta_chrome//:Chrome.app)/Contents/MacOS/Chrome",
],
"//conditions:default": [],
}) + headless_args

edge_args = select({
"@selenium//common:use_pinned_linux_edge": [
"--driver-binary=$(location @linux_edgedriver//:msedgedriver)",
Expand Down Expand Up @@ -59,6 +74,11 @@ BROWSERS = {
"data": chrome_data,
"tags": COMMON_TAGS + ["chrome"],
},
"chrome-beta": {
"args": ["--driver=chrome"] + chrome_beta_args,
"data": chrome_beta_data,
"tags": COMMON_TAGS + ["chrome"],
},
"edge": {
"args": ["--driver=edge"] + edge_args,
"data": edge_data,
Expand Down
Loading