Skip to content

Renaming variable and converting it to nullable bool? #16138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2025
Merged

Renaming variable and converting it to nullable bool? #16138

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77fe46c
Renaming variable and converting it to nullable bool?
diemol Aug 6, 2025
eea8c6a
Update dotnet/src/webdriver/Firefox/FirefoxDriverService.cs
diemol Aug 7, 2025
069b76c
Merge branch 'trunk' into dotnet_rename_log_truncate_nullable
diemol Aug 7, 2025
8bae864
Merge branch 'trunk' into dotnet_rename_log_truncate_nullable
diemol Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions dotnet/src/webdriver/Firefox/FirefoxDriverService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,13 @@ protected override DriverOptions GetDefaultDriverOptions()
public string? LogPath { get; set; }

/// <summary>
/// Disable truncation of long log lines in GeckoDriver.
/// Gets or sets a value indicating whether to disable truncation of long log lines in GeckoDriver.
/// </summary>
public bool LogNoTruncate { get; set; }
/// <remarks>
/// A <see langword="null"/> value indicates no log truncation setting to specify.
/// Set to <see langword="true"/> to disable truncation, or <see langword="false"/> to enable truncation.
/// </remarks>
public bool? LogTruncate { get; set; }

/// <summary>
/// Directory in which GeckoDriver creates profiles.
Expand Down Expand Up @@ -199,7 +203,7 @@ protected override string CommandLineArguments
argsBuilder.Append(" --jsdebugger");
}

if (this.LogNoTruncate)
if (this.LogTruncate.HasValue && this.LogTruncate.Value)
{
argsBuilder.Append(" --log-no-truncate");
}
Expand Down
Loading