-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[grid] update to netty 4.2.4 #16194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] update to netty 4.2.4 #16194
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
4e54a5c
to
ed9cd12
Compare
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This would be great, since I also just saw the CVE notice for version < 4.1.123.Final and want to do the upgrade. However, you already did it. |
Signed-off-by: Viet Nguyen Duc <[email protected]> # Conflicts: # java/maven_install.json
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Update advisories GHSA-3p8m-j85q-pgmj and GHSA-fghv-69vj-qj49 We are unable to bump netty-codec or netty-codec-http to a newer version without breaking the build. Upstream already has a fix in place for a future version, and we should await for a new build with the fixed versions. More information: SeleniumHQ/selenium#16194 Signed-off-by: David Negreira <[email protected]>
Update advisories GHSA-3p8m-j85q-pgmj and GHSA-fghv-69vj-qj49 We are unable to bump netty-codec or netty-codec-http to a newer version without breaking the build. Upstream already has a fix in place for a future version, and we should await for a new build with the fixed versions. More information: SeleniumHQ/selenium#16194
Update advisories GHSA-3p8m-j85q-pgmj and GHSA-fghv-69vj-qj49 We are unable to bump netty-codec or netty-codec-http to a newer version without breaking the build. Upstream already has a fix in place for a future version, and we should await for a new build with the fixed versions. More information: SeleniumHQ/selenium#16194 Signed-off-by: David Negreira <[email protected]>
User description
🔗 Related Issues
💥 What does this PR do?
Update to netty 4.2.4, add the dependencies needed for redis tests to pass with the new netty version.
🔧 Implementation Notes
I did follow most of the migration guide at https://netty.io/wiki/netty-4.2-migration-guide.html, but:
memory allocator
for testing, as we should have not a high throughputSelfSignedCertificate
for now, as it is unclear how to use the newCertificateBuilder
correct💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Update Netty from 4.1.121.Final to 4.2.4.Final
Migrate to new MultiThreadIoEventLoopGroup API
Add required dependencies for Redis tests compatibility
Update Maven dependencies and build configurations
Diagram Walkthrough
File Walkthrough
NettyServer.java
Migrate to Netty 4.2 event loop API
java/src/org/openqa/selenium/netty/server/NettyServer.java
MODULE.bazel
Update Netty BOM and add dependencies
MODULE.bazel
maven_install.json
Maven dependency resolution updates
java/maven_install.json
BUILD.bazel
Add Redis module dependencies
java/src/org/openqa/selenium/redis/BUILD.bazel