Skip to content

[java] Unifying select class #16220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2025
Merged

[java] Unifying select class #16220

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a96c86d
Updated Java Language Level to the JDK_17 for IntelliJ IDEA
vicky-iv Aug 19, 2025
12d83f0
[java] Fix select being able to select options hidden by css rules
vicky-iv Aug 20, 2025
737d420
[java] Formatted with ./scripts/format.sh
vicky-iv Aug 20, 2025
5d54e75
[java] Change the JDK setting for IntelliJ back to JDK 11
vicky-iv Aug 20, 2025
8dcc0a2
Merge branch 'trunk' into java-unifying-select-class
diemol Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion java/java.iml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<component name="ModuleRunConfigurationManager">
<shared />
</component>
<component name="NewModuleRootManager" LANGUAGE_LEVEL="JDK_11">
<component name="NewModuleRootManager" LANGUAGE_LEVEL="JDK_17">
<output url="file://$MODULE_DIR$/build/production" />
<output-test url="file://$MODULE_DIR$/build/test" />
<exclude-output />
Expand Down
5 changes: 5 additions & 0 deletions java/src/org/openqa/selenium/support/ui/Select.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,16 @@ public WebElement getFirstSelectedOption() {
@Override
public void selectByVisibleText(String text) {
assertSelectIsEnabled();
assertSelectIsVisible();

// try to find the option via XPATH ...
List<WebElement> options =
element.findElements(
By.xpath(".//option[normalize-space(.) = " + Quotes.escape(text) + "]"));

for (WebElement option : options) {
if (!hasCssPropertyAndVisible(option))
throw new NoSuchElementException("Invisible option with text: " + text);
setSelected(option, true);
if (!isMultiple()) {
return;
Expand All @@ -154,6 +157,8 @@ public void selectByVisibleText(String text) {

for (WebElement option : candidates) {
if (trimmed.equals(option.getText().trim())) {
if (!hasCssPropertyAndVisible(option))
throw new NoSuchElementException("Invisible option with text: " + text);
setSelected(option, true);
if (!isMultiple()) {
return;
Expand Down
22 changes: 20 additions & 2 deletions java/test/org/openqa/selenium/support/ui/SelectElementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
import org.openqa.selenium.testing.Ignore;
import org.openqa.selenium.testing.JupiterTestBase;

import java.util.Arrays;
import java.util.List;

class SelectElementTest extends JupiterTestBase {

@BeforeEach
Expand Down Expand Up @@ -176,8 +179,11 @@ void shouldNotAllowInvisibleOptionsToBeSelectedByContainsVisibleText() {
WebElement selectElement = driver.findElement(By.id("invisible_multi_select"));
Select select = new Select(selectElement);

assertThatExceptionOfType(NoSuchElementException.class)
.isThrownBy(() -> select.selectByContainsVisibleText("Apples"));
List<String> options = Arrays.asList("Apples", "Pears", "Oranges", "Lemons");
options.forEach(
option ->
assertThatExceptionOfType(NoSuchElementException.class)
.isThrownBy(() -> select.selectByVisibleText(option)));
}

@Test
Expand All @@ -198,6 +204,18 @@ void shouldThrowExceptionOnSelectByVisibleTextIfOptionDisabled() {
.isThrownBy(() -> select.selectByVisibleText("Disabled"));
}

@Test
void shouldThrowExceptionOnSelectByVisibleTextIfOptionHidden() {
WebElement selectElement = driver.findElement(By.id("invisible_multi_select"));
Select select = new Select(selectElement);

List<String> options = Arrays.asList("Apples", "Pears", "Oranges", "Lemons");
options.forEach(
option ->
assertThatExceptionOfType(NoSuchElementException.class)
.isThrownBy(() -> select.selectByVisibleText(option)));
}

@Test
void shouldAllowOptionsToBeSelectedByIndex() {
WebElement selectElement = driver.findElement(By.name("select_empty_multiple"));
Expand Down
Loading