Skip to content

Conversation

cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Sep 8, 2025

User description

💥 What does this PR do?

  • Bump version of setup-python to the latest to keep CI up to date
  • Bump vesion of tox used in Python workflows

🔄 Types of changes

  • CI/Build update

PR Type

Other


Description

  • Bump setup-python action from v4/v5 to v6

  • Update tox version from 4.27.0 to 4.30.2


Diagram Walkthrough

flowchart LR
  A["CI Workflows"] --> B["setup-python v6"]
  A --> C["tox 4.30.2"]
Loading

File Walkthrough

Relevant files
Dependencies
ci-python.yml
Update Python CI dependencies                                                       

.github/workflows/ci-python.yml

  • Update setup-python action from v4 to v6 in docs and mypy jobs
  • Bump tox version from 4.27.0 to 4.30.2
+4/-4     
update-documentation.yml
Bump setup-python version                                                               

.github/workflows/update-documentation.yml

  • Update setup-python action from v5 to v6
+1/-1     

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Sep 8, 2025
Copy link
Contributor

qodo-merge-pro bot commented Sep 8, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Tooling Compatibility

Verify that tox 4.30.2 and actions/setup-python v6 are compatible with the pinned Python 3.9 environment and the existing tox config (py/tox.ini), especially for the docs and mypy environments.

- name: Set up Python 3.9
  uses: actions/setup-python@v6
  with:
    python-version: 3.9
- name: Install dependencies
  run: |
    python -m pip install --upgrade pip
    pip install tox==4.30.2
- name: Generate docs
  run: tox -c py/tox.ini
  env:
Caching Opportunity

Consider enabling actions/setup-python v6 caching for pip to speed up installs in docs and mypy jobs.

- name: Set up Python 3.9
  uses: actions/setup-python@v6
  with:
    python-version: 3.9
- name: Install dependencies
  run: |
    python -m pip install --upgrade pip
    pip install tox==4.30.2
- name: Generate docs
  run: tox -c py/tox.ini
  env:

Copy link
Contributor

qodo-merge-pro bot commented Sep 8, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Learned
best practice
Pin action to commit SHA

Pin the action to the release commit SHA (with a comment for the version)
instead of a floating tag.

.github/workflows/ci-python.yml [24]

-uses: actions/setup-python@v6
+uses: actions/setup-python@<commit-sha>  # v6
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why:
Relevant best practice - Pin GitHub Actions by commit SHA to prevent supply-chain attacks and ensure reproducible builds.

Low
  • More

@cgoldberg cgoldberg merged commit d6b9bc4 into SeleniumHQ:trunk Sep 8, 2025
12 checks passed
@cgoldberg cgoldberg deleted the py-bump-setup-workflows branch September 8, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants