Skip to content

[py] Fix type annotations in the chromium webdriver file #16309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 15, 2025
+9 −7
Merged

[py] Fix type annotations in the chromium webdriver file #16309

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf60959
fixed mypy errors in the chromium webdriver file
pallavigitwork Sep 9, 2025
44fefad
Merge branch 'trunk' into Fix15697-6
cgoldberg Sep 9, 2025
077bb88
expanded imports and removed optional for vars based on information f…
pallavigitwork Sep 9, 2025
b0f6505
Merge branch 'trunk' into Fix15697-6
pallavigitwork Sep 10, 2025
9565ce3
Merge branch 'trunk' into Fix15697-6
pallavigitwork Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions py/selenium/webdriver/chromium/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@

from selenium.webdriver.chromium.remote_connection import ChromiumRemoteConnection
from selenium.webdriver.common.driver_finder import DriverFinder
from selenium.webdriver.common.options import ArgOptions
from selenium.webdriver.common.service import Service
from selenium.webdriver.remote.command import Command
from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver

from .options import ChromiumOptions
from .service import ChromiumService


class ChromiumDriver(RemoteWebDriver):
"""Controls the WebDriver instance of ChromiumDriver and allows you to
Expand All @@ -33,8 +34,8 @@ def __init__(
self,
browser_name: Optional[str] = None,
vendor_prefix: Optional[str] = None,
options: ArgOptions = ArgOptions(),
service: Optional[Service] = None,
options: Optional[ChromiumOptions] = None,
service: Optional[ChromiumService] = None,
keep_alive: bool = True,
) -> None:
"""Creates a new WebDriver instance of the ChromiumDriver. Starts the
Expand All @@ -47,7 +48,9 @@ def __init__(
- service - Service object for handling the browser driver if you need to pass extra details
- keep_alive - Whether to configure ChromiumRemoteConnection to use HTTP keep-alive.
"""
self.service = service

self.service = service if service else ChromiumService()
options = options if options else ChromiumOptions()

finder = DriverFinder(self.service, options)
if finder.get_browser_path():
Expand All @@ -59,8 +62,8 @@ def __init__(

executor = ChromiumRemoteConnection(
remote_server_addr=self.service.service_url,
browser_name=browser_name,
vendor_prefix=vendor_prefix,
browser_name=str(browser_name),
vendor_prefix=str(vendor_prefix),
keep_alive=keep_alive,
ignore_proxy=options._ignore_local_proxy,
)
Expand Down