Skip to content

[js][bidi] add asMap() to the Header class #16321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+21 −1
Open

[js][bidi] add asMap() to the Header class #16321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions javascript/selenium-webdriver/bidi/networkTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,17 @@ class Header {
get value() {
return this._value
}

/**
* Converts the Header to a map.
* @returns {Map<string, string>} A map representation of the Header.
*/
asMap() {
const map = new Map()
map.set('name', this._name)
map.set('value', Object.fromEntries(this._value.asMap()))
return map
}
}

/**
Expand Down
11 changes: 10 additions & 1 deletion javascript/selenium-webdriver/test/bidi/network_commands_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const assert = require('node:assert')
const { Browser, By } = require('selenium-webdriver')
const { Pages, suite } = require('../../lib/test')
const { Network } = require('selenium-webdriver/bidi/network')
const { Header, BytesValue } = require('selenium-webdriver/bidi/networkTypes')
const { AddInterceptParameters } = require('selenium-webdriver/bidi/addInterceptParameters')
const { InterceptPhase } = require('selenium-webdriver/bidi/interceptPhase')
const { until } = require('selenium-webdriver/index')
Expand Down Expand Up @@ -154,13 +155,21 @@ suite(
let counter = 0

await network.beforeRequestSent(async (event) => {
await network.provideResponse(new ProvideResponseParameters(event.request.request))
await network.provideResponse(new ProvideResponseParameters(event.request.request)
.statusCode(200)
.headers([
new Header("Content-Type", new BytesValue("string", "text/html"))
])
.body(new BytesValue("string", "<html><body>Hello world</body></html>"))
)
counter = counter + 1
})

await driver.get(Pages.logEntryAdded)
await driver.wait(until.elementTextContains(driver.findElement(By.css('body')), 'Hello world'));

assert.strictEqual(counter >= 1, true)
assert.equal((await driver.getPageSource()).includes('Hello world'), true)
})
})
},
Expand Down
Loading