Skip to content

[java] Added nullMarked and Nullable annotations to ExecuteMethod Interface #16354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
+6 −1
Open

[java] Added nullMarked and Nullable annotations to ExecuteMethod Interface #16354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
168cf7a
Add nullability annotations to ExecuteMethod interface parameters
iampopovich Sep 27, 2025
23893fb
Add nullability annotations to RemoteExecuteMethod class
iampopovich Sep 27, 2025
3bc24e1
Remove unnecessary blank line in ExecuteMethod interface
iampopovich Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion java/src/org/openqa/selenium/remote/ExecuteMethod.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@
package org.openqa.selenium.remote;

import java.util.Map;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

/**
* An encapsulation of {@link org.openqa.selenium.remote.RemoteWebDriver#executeScript(String,
* Object...)}.
*/
@NullMarked
public interface ExecuteMethod {
/**
* Execute the given command on the remote webdriver server. Any exceptions will be thrown by the
Expand All @@ -32,5 +35,5 @@ public interface ExecuteMethod {
* @param parameters The parameters to execute that command with
* @return The result of {@link Response#getValue()}.
*/
Object execute(String commandName, Map<String, ?> parameters);
@Nullable Object execute(String commandName, @Nullable Map<String, ?> parameters);
}
2 changes: 2 additions & 0 deletions java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@
package org.openqa.selenium.remote;

import java.util.Map;
import org.jspecify.annotations.NullMarked;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WrapsDriver;
import org.openqa.selenium.internal.Require;

@NullMarked
public class RemoteExecuteMethod implements ExecuteMethod, WrapsDriver {
private final RemoteWebDriver driver;

Expand Down