-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py][build] Python CI - add unit test job and windows integration tests to GH runners #16362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py][build] Python CI - add unit test job and windows integration tests to GH runners #16362
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
💥 What does this PR do?
This PR updates Python's CI workflow:
unit-tests
job to run unit tests on Ubuntu/MacOS on the GH runnersThis also fixes an assertion in a unit test that was broken on Windows.
🔧 Implementation Notes
We were not currently running any Python tests on Windows in CI. We have some Windows platform-specific code in the Python bindings and not all maintainers have a Windows system to test against.
💡 Additional Considerations
This might make the CI runs slightly longer.
🔄 Types of changes
PR Type
Tests
Description
Add unit test job for Windows and Ubuntu platforms
Add Chrome/Windows integration test configuration
Expand CI coverage for Windows platform testing
Diagram Walkthrough
File Walkthrough
ci-python.yml
Expand CI with unit tests and Windows support
.github/workflows/ci-python.yml
unit-tests
job with Windows and Ubuntu matrix