-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[grid] UI Light/Dark Mode Toggle #16364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
🔗 Related Issues
💥 What does this PR do?
Fixes #16363
Preview
Screen.Recording.2025-10-01.at.21.37.09.mp4
UI theme switching system with system preference detection and user override capability
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Add theme toggle component with light/dark/system modes
Implement theme context provider with localStorage persistence
Create dark theme with GitHub-inspired colors
Update TopBar to include theme toggle button
Diagram Walkthrough
File Walkthrough
7 files
Create theme toggle button component
Add theme toggle to top bar
Create theme context with system detection
Add custom theme hook implementation
Replace theme provider with custom implementation
Refactor to use new theme system
Create light and dark theme definitions
3 files
Add theme hook mock for testing
Add theme toggle component tests
Update TopBar tests with theme mocking