-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rb] Update Chrome/Edge args for test environment #16376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Update Chrome/Edge args for test environment #16376
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
PR Code Suggestions ✨Explore these optional code suggestions:
|
All Ruby tests pass in CI |
User description
💥 What does this PR do?
This PR updates the args used when starting Chrome and Edge for internal Ruby tests
--disable-gpu
(this used to be necessary for the old headless mode on Windows)--headless=chrome
to--headless
(old headless mode was removed in Chrome 112, and these args now do the same thing)🔄 Types of changes
PR Type
Tests
Description
Update Chrome/Edge headless argument from
--headless=chrome
to--headless
Remove deprecated
--disable-gpu
argument for both browsersModernize browser launch arguments for Ruby test environment
Diagram Walkthrough
File Walkthrough
test_environment.rb
Modernize Chrome/Edge browser launch arguments
rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
--headless=chrome
to--headless
forChrome and Edge
--disable-gpu
argument from both browserconfigurations