-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[java] Linux ARM "os.arch" system property is "aarch64" #16381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
PR Code Suggestions ✨Explore these optional code suggestions:
|
Seems like the failing test times out. |
This is a good addition - thank you @mkurz ! |
Hopefully we will be supporting Linux and Windows on ARM soon, and we can update the platform detection code. |
I am using and maintaining Asahi Arch Linux ARM, which is just a thin layer on top of Arch Linux ARM, and I can build and run selenium manager from you repo without any problems. So regarding selenium manager I think all you have to do is build it for the geckodriver can also be build for For the chromiumdriver it's similiar, either you compile chromium yourself (which takes quite a while...) or you use the precompiled binaries from the chromium package again (https://eu.mirror.archlinuxarm.org/aarch64/extra/). (currently chromium is totally outdated in Arch Linux ARM because they have a problem in the build setup). |
We already have PRs open for building Selenium Manager on ARM64 for Linux and Windows. However, we have no intention of publishing our own geckodriver/chromedriver builds. (Mozilla already publishes geckodriver for ARM anyway). |
User description
💥 What does this PR do?
I am running Linux on a MacBook Pro M1 via https://asahi-alarm.org/.
The architecture of this machine is identified as
aarch64
in Java (and in general).When selenium tries to start selenium manager it fails because it tries to execute the x86-64 binary, which of course does not work on an aarch64 system.
🔧 Implementation Notes
Just also checking for
aarch64
.. Easy.🔄 Types of changes
PR Type
Bug fix
Description
Add support for detecting
aarch64
architecture on Linux systemsFix Selenium Manager binary selection for ARM-based Linux platforms
Improve error handling for unsupported ARM architectures
Diagram Walkthrough
File Walkthrough
SeleniumManager.java
Add aarch64 architecture detection support
java/src/org/openqa/selenium/manager/SeleniumManager.java
aarch64
getBinary()
method