Skip to content

Conversation

ManeeshProg
Copy link

@ManeeshProg ManeeshProg commented Oct 6, 2025

User description

##16385 Related Issues

What does this PR do?
Relaxes the json dependency restriction in the Ruby gemspec.
Previously, the dependency was locked to <= 2.13.2, which caused unnecessary downgrades of the json gem in production environments.
This PR updates it to allow >= 2.13.0.

Changed this line in rb/selenium-webdriver.gemspec:

  • s.add_dependency "json", "<= 2.13.2"
  • s.add_dependency "json", ">= 2.13.0"

PR Type

Enhancement


Description

  • Relaxed json dependency from <= 2.13.2 to >= 2.13.0

  • Added Apache License 2.0 file to Ruby binding

  • Added NOTICE file with copyright information


Diagram Walkthrough

flowchart LR
  A["gemspec dependency"] -- "relaxed restriction" --> B["json >= 2.13.0"]
  C["Ruby binding"] -- "added" --> D["Apache License"]
  C -- "added" --> E["NOTICE file"]
Loading

File Walkthrough

Relevant files
Dependencies
selenium-webdriver.gemspec
Relaxed json dependency version constraint                             

rb/selenium-webdriver.gemspec

  • Changed json dependency from <= 2.13.2 to >= 2.13.0
  • Added comment suggesting complete removal of restriction
+1/-1     
Documentation
LICENSE
Added Apache License 2.0 file                                                       

rb/LICENSE

  • Added complete Apache License 2.0 text
  • Copyright assigned to Software Freedom Conservancy (SFC)
+202/-0 
NOTICE
Added copyright notice file                                                           

rb/NOTICE

  • Added copyright notice for 2011-2025 Software Freedom Conservancy
  • Added copyright notice for 2004-2011 Selenium committers
+2/-0     

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2025

CLA assistant check
All committers have signed the CLA.

@selenium-ci selenium-ci added the C-rb Ruby Bindings label Oct 6, 2025
Copy link
Contributor

qodo-merge-pro bot commented Oct 6, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Copy link
Contributor

qodo-merge-pro bot commented Oct 6, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Remove invalid and unnecessary dependency

Remove the dependency on the json gem, as the specified version ">= 2.13.0" is
invalid and the gem is included in modern Ruby versions by default.

rb/selenium-webdriver.gemspec [53]

-s.add_dependency "json", ">= 2.13.0" #—or simply remove the restriction entirely, since json is part of the Ruby stdlib for most Ruby versions.
 
+
  • Apply / Chat
Suggestion importance[1-10]: 10

__

Why: The suggestion correctly identifies that the specified json gem version ">= 2.13.0" is invalid and does not exist, which would break dependency resolution for users.

High
  • More

@ManeeshProg
Copy link
Author

Its A minor issue that is Having a 2 way deadlock. That is interfering with the json build version. So i kindly request the Mediators to take necessary action

@cgoldberg
Copy link
Member

I don't know if this resolves the dependency issue, but there are problems with this PR:

  • We don't want to add copies of LICENSE and NOTICE under the ./rb directory. If they are needed for packaging, they should be symlinks to the files in the root of the repo
  • We don't want to commit the binary gem to the source tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants