Skip to content

Conversation

cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Oct 7, 2025

User description

💥 What does this PR do?

This PR updates the chromedriver and msedgedriver service logging tests to make them more flexible due to some recent changes made in the driver logging.

🔄 Types of changes

  • Build/Tests

PR Type

Tests


Description

  • Update Chrome and Edge driver service logging test assertions

  • Replace specific log message checks with flexible pattern matching

  • Fix test failures due to driver logging format changes


Diagram Walkthrough

flowchart LR
  A["Old Tests"] -- "Replace specific strings" --> B["Updated Tests"]
  B -- "Use flexible patterns" --> C["Robust Assertions"]
Loading

File Walkthrough

Relevant files
Tests
chrome_service_tests.py
Update Chrome service logging test assertions                       

py/test/selenium/webdriver/chrome/chrome_service_tests.py

  • Replace specific "Starting ChromeDriver" assertions with flexible
    "Starting" pattern
  • Change from reading single line to reading entire file content
  • Add "started successfully" assertion for better validation
  • Update test_log_output_null_default to expect log output instead of
    none
+10/-4   
edge_service_tests.py
Update Edge service logging test assertions                           

py/test/selenium/webdriver/edge/edge_service_tests.py

  • Replace specific "Starting Microsoft Edge WebDriver" assertions with
    flexible "Starting" pattern
  • Change from reading single line to reading entire file content
  • Add "started successfully" assertion for better validation
  • Update test_log_output_null_default to expect log output instead of
    none
+10/-4   

@selenium-ci selenium-ci added the C-py Python Bindings label Oct 7, 2025
Copy link
Contributor

qodo-merge-pro bot commented Oct 7, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@SeleniumHQ SeleniumHQ deleted a comment from qodo-merge-pro bot Oct 7, 2025
@navin772
Copy link
Member

navin772 commented Oct 7, 2025

Any specific reason to add sleep, it works for me without sleep

@cgoldberg
Copy link
Member Author

Any specific reason to add sleep

I only added sleeps because some tests were already using them and I wanted them all to be consistent. I'll remove them from all tests and see if they still pass.

@cgoldberg cgoldberg merged commit 4e5a674 into SeleniumHQ:trunk Oct 7, 2025
18 checks passed
@cgoldberg cgoldberg deleted the py-fix-chrome-edge-service-log-tests branch October 7, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants