Skip to content

[py][build] Re-add Windows to CI workflows #16396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 9, 2025
Merged

[py][build] Re-add Windows to CI workflows #16396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c53f9a
[py] Re-add Windows to CI workflows
cgoldberg Oct 7, 2025
f135738
[py] Fix workflow syntax
cgoldberg Oct 7, 2025
8c0bc60
[py] Remove Firefox on Windows because it's insanely slow
cgoldberg Oct 7, 2025
9ba8536
Merge branch 'trunk' into py-readd-windows-ci-workflows
cgoldberg Oct 8, 2025
d285ee2
[py] Removing unit tests on Windows due to random timeouts on the GHA…
cgoldberg Oct 8, 2025
72626e4
[py] Rename cache-key
cgoldberg Oct 8, 2025
8dc8e7a
Remove OS from cache keys
cgoldberg Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions .github/workflows/ci-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ jobs:
with:
name: Build
cache-key: py-build
run: bazel build //py:selenium-wheel //py:selenium-sdist
run: |
bazel build //py:selenium-wheel //py:selenium-sdist

docs:
name: Documentation
Expand All @@ -29,7 +30,8 @@ jobs:
python -m pip install --upgrade pip
pip install tox==4.30.2
- name: Generate docs
run: tox -c py/tox.ini
run: |
tox -c py/tox.ini
env:
TOXENV: docs

Expand Down Expand Up @@ -68,7 +70,8 @@ jobs:
name: Unit Tests (${{ matrix.os }})
os: ${{ matrix.os }}
cache-key: python-unit-test-${{ matrix.os }}
run: bazel test //py:unit
run: |
bazel test //py:unit

remote-tests:
name: Remote Tests
Expand All @@ -83,7 +86,8 @@ jobs:
name: Integration Tests (remote, ${{ matrix.browser }})
browser: ${{ matrix.browser }}
cache-key: py-remote-${{ matrix.browser }}
run: bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-remote
run: |
bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-remote

browser-tests:
name: Browser Tests
Expand All @@ -107,7 +111,28 @@ jobs:
run: |
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:common-${{ matrix.browser }}-bidi //py:test-${{ matrix.browser }}

safari-tests:
browser-tests-windows:
name: Browser Tests
needs: build
uses: ./.github/workflows/bazel.yml
strategy:
fail-fast: false
matrix:
include:
- browser: chrome
os: windows
- browser: edge
os: windows
with:
name: Integration Tests (${{ matrix.browser }}, ${{ matrix.os }})
browser: ${{ matrix.browser }}
os: ${{ matrix.os }}
cache-key: py-browser-${{ matrix.browser }}
run: |
fsutil 8dot3name set 0
bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:common-${{ matrix.browser }}-bidi //py:test-${{ matrix.browser }}

browser-tests-macos:
name: Browser Tests
needs: build
uses: ./.github/workflows/bazel.yml
Expand Down
1 change: 0 additions & 1 deletion py/test/unit/selenium/webdriver/remote/new_session_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# specific language governing permissions and limitations
# under the License.


from importlib import import_module

import pytest
Expand Down
1 change: 0 additions & 1 deletion py/test/unit/selenium/webdriver/remote/subtyping_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# specific language governing permissions and limitations
# under the License.


from selenium.webdriver.remote.webdriver import WebDriver, WebElement


Expand Down