Skip to content

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Oct 8, 2025

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Oct 8, 2025
Copy link
Contributor

qodo-merge-pro bot commented Oct 8, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Copy link
Contributor

qodo-merge-pro bot commented Oct 8, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Centralize version string in a variable

To improve maintainability, define the hardcoded Chrome version string
"141.0.7390.65" as a variable and use it to construct the download URLs.

common/repositories.bzl [200-269]

+    _CHROME_VERSION = "141.0.7390.65"
+
     http_archive(
         name = "linux_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/141.0.7390.65/linux64/chrome-linux64.zip",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/{v}/linux64/chrome-linux64.zip".format(v = _CHROME_VERSION),
         sha256 = "c70aee4a995d15349967c3630c382c8c61b7fba7f970930adc293e58ad1ef65e",
         build_file_content = """
 ...
 """,
     )
     http_archive(
         name = "mac_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/141.0.7390.65/mac-x64/chrome-mac-x64.zip",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/{v}/mac-x64/chrome-mac-x64.zip".format(v = _CHROME_VERSION),
         sha256 = "7dac9cac8304cc53c6ae297a3d4e1b4fab2818223fbeaa9cb9eac501bd9cd30a",
         strip_prefix = "chrome-mac-x64",
 ...
     )
     http_archive(
         name = "linux_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/141.0.7390.65/linux64/chromedriver-linux64.zip",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/{v}/linux64/chromedriver-linux64.zip".format(v = _CHROME_VERSION),
         sha256 = "eabcd234f516bb85ceeeb9368f694a3b7d3b3f2002d37f2a986f1a212bc9f696",
         strip_prefix = "chromedriver-linux64",
 ...
     )
 
     http_archive(
         name = "mac_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/141.0.7390.65/mac-x64/chromedriver-mac-x64.zip",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/{v}/mac-x64/chromedriver-mac-x64.zip".format(v = _CHROME_VERSION),
         sha256 = "8776657e5718701f9f13740e04efbcff1cb08bcfccc7d459d88008775c05d9e6",
         strip_prefix = "chromedriver-mac-x64",
 ...
     )

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies repeated hardcoded version strings and proposes centralizing them into a variable, which improves maintainability and reduces the risk of errors in future updates.

Medium
  • Update

@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch from 59a7cb4 to 78efd45 Compare October 9, 2025 00:45
@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch from 78efd45 to 075db3b Compare October 10, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-build Includes scripting, bazel and CI integrations Review effort 2/5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant