[dotnet] Help more .NETFramework projects to copy SM binaries to output

[nvborisenko]

User description

🔗 Related Issues

Fixes #16400

🔄 Types of changes

• Bug fix (backwards compatible)

---

PR Type

Bug fix

---

Description

• Remove RuntimeIdentifiers condition check in MSBuild targets

• Enable Selenium Manager binary copying for more .NET Framework projects

---

Diagram Walkthrough

flowchart LR
  A["MSBuild Condition"] -- "Remove RuntimeIdentifiers check" --> B["More Projects Supported"]
  B --> C["Selenium Manager Binaries Copied"]

Loading

File Walkthrough

	Relevant files
Bug fix	Selenium.WebDriver.targets Simplify MSBuild condition for binary copying                        dotnet/src/webdriver/assets/nuget/build/Selenium.WebDriver.targets Remove RuntimeIdentifiers empty check from MSBuild condition Simplify condition to only check RuntimeIdentifier and target framework +1/-1

---

[qodo-merge-pro]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡	🎫 #16400 🟢 Modify build/packaging so that absence of RuntimeIdentifiers does not block copying the Selenium Manager binary. Maintain backward compatibility and not affect projects that explicitly set a RuntimeIdentifier. ⚪ Ensure Selenium Manager binary (selenium-manager.exe) is copied/deployed for .NET Framework projects using ClickOnce/VSTO after updating to v4.36.0+ (regression from 4.35.0).
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	No custom compliance provided Follow the guide to enable custom compliance check.

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Learned best practice	Reintroduce multi-RID empty check Restore the $(RuntimeIdentifiers) empty check to ensure the copy runs only when both single and multiple RIDs are unset, preventing missed copies for multi-RID projects. dotnet/src/webdriver/assets/nuget/build/Selenium.WebDriver.targets [6-10] -<ItemGroup Condition="'$(RuntimeIdentifier)' == '' and '$(TargetFrameworkIdentifier)' == '.NETFramework'"> +<ItemGroup Condition="'$(RuntimeIdentifier)' == '' and '$(RuntimeIdentifiers)' == '' and '$(TargetFrameworkIdentifier)' == '.NETFramework'"> <Content Include="$(MSBuildThisFileDirectory)..\runtimes\win\native\selenium-manager.exe"> <Link>runtimes\win\native\%(Filename)%(Extension)</Link> <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> <Visible>False</Visible> Apply / Chat Suggestion importance[1-10]: 6 __ Why: Relevant best practice - Validate inputs and states early to prevent logic errors; avoid narrowing conditions that can skip necessary behavior for valid configurations.	Low
More