Skip to content

Conversation

cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Oct 13, 2025

User description

💥 What does this PR do?

This PR adds methods that raise NotImplementedError if you try to call delete_downloadable_files() on a local driver instance. That method only works on Remote WebDriver. This is similar behavior to what is already done in get_downloadable_files().

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix


Description

  • Add delete_downloadable_files() method raising NotImplementedError across all local driver classes

  • Ensures consistent behavior with existing get_downloadable_files() and download_file() methods

  • Prevents calling remote-only functionality on local driver instances


Diagram Walkthrough

flowchart LR
  A["Local Driver Classes"] --> B["Add delete_downloadable_files()"]
  B --> C["Raise NotImplementedError"]
  C --> D["Consistent with Remote-Only Methods"]
Loading

File Walkthrough

Relevant files
Bug fix
webdriver.py
Add NotImplementedError for delete downloads in Chromium driver

py/selenium/webdriver/chromium/webdriver.py

  • Added delete_downloadable_files() method that raises
    NotImplementedError
+3/-0     
webdriver.py
Add NotImplementedError for delete downloads in Firefox driver

py/selenium/webdriver/firefox/webdriver.py

  • Added delete_downloadable_files() method that raises
    NotImplementedError
+3/-0     
webdriver.py
Add NotImplementedError for delete downloads in IE driver

py/selenium/webdriver/ie/webdriver.py

  • Added delete_downloadable_files() method that raises
    NotImplementedError
+3/-0     
webdriver.py
Add NotImplementedError for delete downloads in Safari driver

py/selenium/webdriver/safari/webdriver.py

  • Added delete_downloadable_files() method that raises
    NotImplementedError
+3/-0     
webdriver.py
Add NotImplementedError for delete downloads in WebKitGTK driver

py/selenium/webdriver/webkitgtk/webdriver.py

  • Added delete_downloadable_files() method that raises
    NotImplementedError
+3/-0     
webdriver.py
Add NotImplementedError for delete downloads in WPEWebKit driver

py/selenium/webdriver/wpewebkit/webdriver.py

  • Added delete_downloadable_files() method that raises
    NotImplementedError
+3/-0     

@cgoldberg cgoldberg added the C-py Python Bindings label Oct 13, 2025
@SeleniumHQ SeleniumHQ deleted a comment from qodo-merge-pro bot Oct 13, 2025
@SeleniumHQ SeleniumHQ deleted a comment from qodo-merge-pro bot Oct 13, 2025
@diemol diemol merged commit 5454624 into SeleniumHQ:trunk Oct 14, 2025
20 checks passed
@cgoldberg cgoldberg deleted the py-delete-downloads-not-implemented branch October 14, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants