Python: Switch Remote tests to Chrome; update CI; align markers (#16417) #16434
+15
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Summary
This switches the Python Remote tests from Firefox to Chrome and updates CI to match. It also makes the Remote tests honor both Chrome- and Remote-specific xfail markers. Fixes #16417.
What changed
py/conftest.py
.github/workflows/ci-python.yml
Remote test job runs with browser: chrome.
Rakefile
Description updated to “Python Remote tests with Chrome”.
Why
We want Python Remote tests to run on Chrome by default and ensure CI does the same.
How I tested
On macOS with Bazel:
Impact
Only affects Python Remote tests and the Python CI workflow. No changes to other bindings or local driver tests.
PR Type
Tests, Enhancement
Description
Switch Python Remote tests from Firefox to Chrome
Update CI workflow to run Remote tests with Chrome browser
Add support for dual xfail markers (Chrome and Remote) in Remote test configuration
Configure Remote driver with Chrome options and managed downloads
Diagram Walkthrough
File Walkthrough
conftest.py
Switch Remote driver to Chrome with dual marker support
py/conftest.py
FirefoxOptions
toChromeOptions
xfail_chrome
and
xfail_remote
)Remote driver
ci-python.yml
Update CI workflow to use Chrome for Remote tests
.github/workflows/ci-python.yml
firefox
tochrome
Rakefile
Update Rake task description for Chrome
Rakefile
"Python Remote tests with Chrome"