Skip to content

Adapting the browser_protocol file fetching to the file structure change. #16440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
+21 −0
Merged

Adapting the browser_protocol file fetching to the file structure change. #16440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fbbdf1
Fetching all browser_protocol.pdl includes and concatenating them.
diemol Oct 15, 2025
af8bbae
Merge branch 'trunk' into building_cdp_again
diemol Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions scripts/update_cdp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,23 @@ def old_chrome(chrome_milestone):
return str(int(new_chrome(chrome_milestone)) - 3)


def flatten_browser_pdl(file_path, chrome_version):
"""Fetches all included domain .pdl files and concatenates them."""
with open(file_path, "r") as file:
content = file.read()
# Find all include lines
includes = re.findall(r"include domains/([A-Za-z0-9_]+\.pdl)", content)
base_url = f"https://raw.githubusercontent.com/chromium/chromium/{chrome_version}/third_party/blink/public/devtools_protocol/domains/"
concatenated = ""
for domain_file in includes:
url = base_url + domain_file
response = http.request("GET", url)
concatenated += response.data.decode("utf-8") + "\n"
# Overwrite the file with concatenated domains
with open(file_path, "w") as file:
file.write(concatenated)


def add_pdls(chrome_milestone):
source_dir = (
root_dir / f"common/devtools/chromium/v{previous_chrome(chrome_milestone)}"
Expand All @@ -84,6 +101,10 @@ def add_pdls(chrome_milestone):
f"{target_dir}/browser_protocol.pdl",
)

flatten_browser_pdl(
f"{target_dir}/browser_protocol.pdl", chrome_milestone["version"]
)

deps_content = http.request(
"GET",
f"https://raw.githubusercontent.com/chromium/chromium/{chrome_milestone['version']}/DEPS",
Expand Down
Loading