Skip to content

Conversation

navin772
Copy link
Member

@navin772 navin772 commented Oct 15, 2025

User description

🔗 Related Issues

py/test/selenium/webdriver/common/executing_javascript_tests.py::test_should_be_able_to_create_apersistent_value is failing with error tab crashed on CI-RBE but works locally.

The --disable-dev-shm-usage flag resolves this.

💥 What does this PR do?

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • tests

PR Type

Tests


Description

  • Add --disable-dev-shm-usage flag to Chrome and Edge options in test configuration

  • Fixes tab crash issue in CI-RBE environment for persistent value test

  • Applied conditionally only to Chrome and Edge browsers


Diagram Walkthrough

flowchart LR
  A["Test Configuration"] --> B["Options Setup"]
  B --> C["Add --disable-dev-shm-usage"]
  C --> D["Chrome/Edge Browsers"]
Loading

File Walkthrough

Relevant files
Tests
conftest.py
Add dev-shm-usage flag to Chrome/Edge options                       

py/conftest.py

  • Added conditional check for Chrome and Edge browsers
  • Applied --disable-dev-shm-usage argument to browser options
  • Prevents tab crashes in CI-RBE test environment
+3/-0     

@selenium-ci selenium-ci added the C-py Python Bindings label Oct 15, 2025
Copy link
Contributor

qodo-merge-pro bot commented Oct 15, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡
🎫 #1234
🔴 Investigate and resolve why Selenium 2.48.x with Firefox does not trigger JavaScript in an
anchor href on click, whereas 2.47.1 does.
Provide a fix or workaround ensuring JavaScript in link href is executed on click in
Firefox 42 context.
🟡
🎫 #5678
🔴 Diagnose and fix recurring "Error: ConnectFailure (Connection refused)" when instantiating
multiple ChromeDriver instances on Ubuntu 16.04 with Chrome 65/Chromedriver 2.35.
Ensure stable creation of subsequent ChromeDriver instances without connection failures.
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Copy link
Contributor

qodo-merge-pro bot commented Oct 15, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Use driver class for condition

To prevent adding Chrome-specific arguments to other browser options (e.g.,
Firefox for remote drivers), base the condition for adding
--disable-dev-shm-usage on self.driver_class instead of cls_name.

py/conftest.py [259-260]

-if cls_name.lower() in ("chrome", "edge"):
+if self.driver_class in (self.supported_drivers.chrome, self.supported_drivers.edge):
     self._options.add_argument("--disable-dev-shm-usage")
  • Apply / Chat
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies a bug where a Chrome-specific argument could be added to Firefox options if self.driver_class is 'Remote' and options are set to 'chrome'. Using self.driver_class for the condition ensures correctness and consistency with the surrounding code.

Medium
  • Update

@cgoldberg
Copy link
Member

All the Python tests passed on RBE. I'll merge this.

@cgoldberg cgoldberg changed the title [py]: add --disable-dev-shm-usage to options [py]: add --disable-dev-shm-usage to Chrome/Edge options for internal tests Oct 15, 2025
@cgoldberg cgoldberg merged commit b308fbf into SeleniumHQ:trunk Oct 15, 2025
4 checks passed
@navin772 navin772 deleted the add-disable-dev-shm-usage-flag branch October 16, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants