Skip to content

[dotnet] [bidi] Remove unnecessary command type info #16454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
+2 −6
Merged

[dotnet] [bidi] Remove unnecessary command type info #16454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions dotnet/src/webdriver/BiDi/Communication/Command.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,19 @@ namespace OpenQA.Selenium.BiDi.Communication;

public abstract class Command
{
protected Command(string method, Type resultType)
protected Command(string method)
{
Method = method;
ResultType = resultType;
}

[JsonPropertyOrder(1)]
public string Method { get; }

[JsonPropertyOrder(0)]
public long Id { get; internal set; }

[JsonIgnore]
public Type ResultType { get; }
}

internal abstract class Command<TParameters, TResult>(TParameters @params, string method) : Command(method, typeof(TResult))
internal abstract class Command<TParameters, TResult>(TParameters @params, string method) : Command(method)
where TParameters : Parameters
where TResult : EmptyResult
{
Expand Down