Skip to content

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Oct 18, 2025

User description

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed


PR Type

Enhancement


Description

  • Update Microsoft Edge browser to version 141.0.3537.85

  • Update Edge macOS package URL and SHA256 hash

  • Update Edge Linux package URL and SHA256 hash

  • Update Edge Linux driver URL and SHA256 hash


Diagram Walkthrough

flowchart LR
  A["Edge 141.0.3537.71"] -- "version bump" --> B["Edge 141.0.3537.85"]
  B --> C["macOS package updated"]
  B --> D["Linux package updated"]
  B --> E["Linux driver updated"]
Loading

File Walkthrough

Relevant files
Dependencies
repositories.bzl
Update Edge browser and driver versions                                   

common/repositories.bzl

  • Updated Microsoft Edge macOS package from version 141.0.3537.71 to
    141.0.3537.85
  • Updated macOS package URL and SHA256 hash
  • Updated Linux Edge package URL and SHA256 hash
  • Updated Linux Edge driver URL and SHA256 hash
+7/-7     

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Oct 18, 2025
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Dynamically construct path from URL

Dynamically construct the move path for mac_edge from its URL to avoid
hardcoding the version number. This will make future version updates more robust
and less error-prone.

common/repositories.bzl [124-142]

+_mac_edge_url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/856a8ff9-d4dc-4066-8634-f104315b2ca5/MicrosoftEdge-141.0.3537.85.pkg"
+_mac_edge_pkg = _mac_edge_url.split("/")[-1]
+
 pkg_archive(
     name = "mac_edge",
-    url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/856a8ff9-d4dc-4066-8634-f104315b2ca5/MicrosoftEdge-141.0.3537.85.pkg",
+    url = _mac_edge_url,
     sha256 = "5acaff5921f1e58d4065999ace344e858cc7bab555bc019210e15470bb43a530",
     move = {
-        "MicrosoftEdge-141.0.3537.85.pkg/Payload/Microsoft Edge.app": "Edge.app",
+        _mac_edge_pkg + "/Payload/Microsoft Edge.app": "Edge.app",
     },
     build_file_content = """
 ...
 )

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies a hardcoded version in the move path and proposes a dynamic approach using the URL, which improves maintainability and reduces the risk of errors during future updates.

Low
  • More

@navin772 navin772 merged commit 17a5dba into trunk Oct 18, 2025
50 checks passed
@navin772 navin772 deleted the pinned-browser-updates branch October 18, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations Review effort 2/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants