Skip to content

Conversation

cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Oct 20, 2025

User description

💥 What does this PR do?

This PR removes all old references to the Travis CI environment from the codebase, since we no longer use it.

🔧 Implementation Notes

No functional changes to code.

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • CI/Test

PR Type

Other


Description

  • Remove Travis CI environment references from test annotations

  • Delete travis parameter from @Ignore annotation interface

  • Remove isOnTravis() utility method and related conditionals

  • Clean up Travis CI environment variable from Bazel configuration


Diagram Walkthrough

flowchart LR
  A["Travis CI References"] -->|Remove from tests| B["@Ignore Annotations"]
  A -->|Remove utility| C["TestUtilities.java"]
  A -->|Remove from config| D[".bazelrc"]
  A -->|Remove from platform| E["platform.rb"]
  B --> F["Clean test files"]
  C --> G["Delete isOnTravis method"]
  D --> H["Delete TRAVIS env var"]
  E --> I["Delete travis CI detection"]
Loading

File Walkthrough

Relevant files
Cleanup
9 files
ProxySettingTest.java
Remove travis parameter from Ignore annotation                     
+0/-1     
SlowLoadingPageTest.java
Remove travis parameter from Ignore annotation                     
+1/-1     
WindowTest.java
Remove travis parameter from multiple Ignore annotations 
+1/-5     
CombinedInputActionsTest.java
Remove travis parameter from Ignore annotations                   
+0/-3     
ClosureTestStatement.java
Remove isOnTravis conditional and import statement             
+5/-8     
Ignore.java
Remove travis boolean parameter from interface                     
+0/-2     
IgnoreComparator.java
Remove travis condition from ignore logic                               
+1/-2     
TestUtilities.java
Delete isOnTravis utility method                                                 
+0/-4     
platform.rb
Remove Travis CI detection from ci method                               
+0/-2     
Configuration changes
1 files
.bazelrc
Remove TRAVIS environment variable from test config           
+0/-1     

@selenium-ci selenium-ci added C-rb Ruby Bindings C-java Java Bindings B-build Includes scripting, bazel and CI integrations labels Oct 20, 2025
Copy link
Contributor

qodo-merge-pro bot commented Oct 20, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Copy link
Contributor

qodo-merge-pro bot commented Oct 20, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix conditional logic for GitHub Actions
Suggestion Impact:The commit applies the suggested change, updating the condition to remove the extra parentheses and fix the logic for GitHub Actions.

code diff:

     return ignoreList.anyMatch(
         driver ->
             (ignored.contains(driver.value()) || driver.value() == Browser.ALL)
-                && ((!driver.gitHubActions() || TestUtilities.isOnGitHubActions()))
+                && (!driver.gitHubActions() || TestUtilities.isOnGitHubActions())
                 && isOpen(driver.issue()));

Fix the conditional logic for ignoring tests on GitHub Actions. The current
implementation incorrectly ignores tests when the gitHubActions attribute is not
specified.

java/test/org/openqa/selenium/testing/IgnoreComparator.java [52-56]

 return ignoreList.anyMatch(
     driver ->
         (ignored.contains(driver.value()) || driver.value() == Browser.ALL)
-            && ((!driver.gitHubActions() || TestUtilities.isOnGitHubActions()))
+            && (!driver.gitHubActions() || TestUtilities.isOnGitHubActions())
             && isOpen(driver.issue()));

[Suggestion processed]

Suggestion importance[1-10]: 10

__

Why: The suggestion correctly identifies a critical logic bug in the shouldIgnore method. The current logic causes tests to be ignored incorrectly when @Ignore is used without gitHubActions=true, which is a significant flaw introduced by the PR.

High
  • Update

@cgoldberg cgoldberg merged commit 1300833 into SeleniumHQ:trunk Oct 21, 2025
24 checks passed
@cgoldberg cgoldberg deleted the remove-travis-cruft branch October 21, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations C-java Java Bindings C-rb Ruby Bindings Review effort 2/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants