Skip to content

Conversation

@titusfortner
Copy link
Member

@titusfortner titusfortner commented Oct 20, 2025

User description

These have been deprecated for a year, should be good to remove now.


PR Type

Enhancement


Description

  • Remove deprecated LogInspector class and related log entry classes

  • Delete associated RBS type signature files for removed classes

  • Clean up autoload reference and Steepfile configuration

  • Migrate users to newer Script class with driver.script API


Diagram Walkthrough

flowchart LR
  A["Deprecated LogInspector<br/>& Log Entry Classes"] -->|Removed| B["Cleaner Codebase"]
  C["RBS Type Signatures"] -->|Deleted| B
  D["Autoload References"] -->|Cleaned Up| B
  B -->|Users Migrate To| E["Script Class API"]
Loading

File Walkthrough

Relevant files
Cleanup
13 files
bidi.rb
Remove LogInspector autoload reference                                     
+0/-1     
log_inspector.rb
Delete deprecated LogInspector class entirely                       
+0/-147 
base_log_entry.rb
Delete deprecated BaseLogEntry class                                         
+0/-35   
generic_log_entry.rb
Delete deprecated GenericLogEntry class                                   
+0/-33   
console_log_entry.rb
Delete deprecated ConsoleLogEntry class                                   
+0/-35   
javascript_log_entry.rb
Delete deprecated JavascriptLogEntry class                             
+0/-33   
filter_by.rb
Delete deprecated FilterBy class                                                 
+0/-40   
log_inspector.rbs
Delete LogInspector RBS type signature                                     
+0/-33   
base_log_entry.rbs
Delete BaseLogEntry RBS type signature                                     
+0/-25   
generic_log_entry.rbs
Delete GenericLogEntry RBS type signature                               
+0/-13   
console_log_entry.rbs
Delete ConsoleLogEntry RBS type signature                               
+0/-21   
javascript_log_entry.rbs
Delete JavascriptLogEntry RBS type signature                         
+0/-13   
filter_by.rbs
Delete FilterBy RBS type signature                                             
+0/-15   
Configuration changes
1 files
Steepfile
Remove LogInspector from Steepfile ignores                             
+0/-2     

@titusfortner titusfortner requested a review from aguspe October 20, 2025 23:01
@selenium-ci selenium-ci added C-rb Ruby Bindings B-devtools Includes everything BiDi or Chrome DevTools related labels Oct 20, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 20, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 20, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@titusfortner titusfortner merged commit 0606401 into trunk Oct 21, 2025
31 checks passed
@titusfortner titusfortner deleted the rb_dep_log branch October 21, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-devtools Includes everything BiDi or Chrome DevTools related C-rb Ruby Bindings Review effort 2/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants