Skip to content

[rb] error handling improvements #16480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+9 −6
Open

[rb] error handling improvements #16480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
456fc92
[rb] error handling improvements
titusfortner Oct 21, 2025
10be9c7
do not change the error type, just add where issue originates
titusfortner Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rb/lib/selenium/webdriver/bidi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ def send_cmd(method, **params)
raise Error::WebDriverError, error_message(message) if message['error']

message['result']
rescue StandardError => e
raise e, "Unable to send command #{method}: #{e.message}"
end

def error_message(message)
Expand Down
13 changes: 7 additions & 6 deletions rb/lib/selenium/webdriver/common/network.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,13 @@ def clear_handlers
end

def add_authentication_handler(username = nil, password = nil, *filter, pattern_type: nil, &block)
selected_block =
if username && password
proc { |auth| auth.authenticate(username, password) }
else
block
end
selected_block = if block_given?
block
elsif !(username && password)
raise ArgumentError, 'Need to provide either a block or both username and password'
else
proc { |auth| auth.authenticate(username, password) }
end

add_handler(
:auth_required,
Expand Down
Loading