-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[build] remove more ruby test targets that do not apply and support r… #16484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
…emote-bidi targets for each test
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
|
I think these new remote-bidi failures are flaky and will be fixed by #16487 |
|
Moving to draft, still needs optimizing |
User description
I did not figure out how to prevent the bidi specific targets in the main webdriver directory from being added to non-supported browsers, but Ruby blocks that from running right now, so it is more housekeeping than performance speedup.
As in, these targets don't matter but will still be generated:
PR Type
Enhancement, Tests
Description
Adds remote-bidi test targets for BiDi-supported browsers
Restricts bidi tests to explicitly supported browsers via
BIDI_BROWSERSExpands bidi test coverage with remote execution capability
Updates documentation with bidi testing guidance and examples
Diagram Walkthrough
File Walkthrough
tests.bzl
Add bidi browser filtering and remote-bidi test targetsrb/spec/tests.bzl
BIDI_BROWSERSconstant listing supported browsers for biditesting
BIDI_BROWSERSremote-biditest targets alongside existingbiditargetsdependencies
BUILD.bazel
Restrict bidi tests to supported browsersrb/spec/integration/selenium/webdriver/bidi/BUILD.bazel
BIDI_BROWSERSconstant from tests.bzlbrowsersparameterREADME.md
Document bidi testing and remote-bidi test targetsREADME.md
--test_tag_filters bidiWEBDRIVER_BIDIenvironment variable for enabling web socketURLs
chrome-betato supported browsers list