-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[java] remove Apache Commons dependency #16865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
| "sources": "52dd9db2e64649143631680ca6dabcd75e4457761dddf5e72406086cd19eee88" | ||
| }, | ||
| "version": "1.6.0" | ||
| "version": "1.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly this line means?
Looks like instead of removing "commons-exec" dependency, you downgraded its version from "1.6.0" to "1.4.0"? @titusfortner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense it is a transitive dependency
If we don't need it for our code, we should let whatever does need it set the version, unless there's a security issue or bug, or a potential concern. I don't think any of those apply to this.
User description
🔗 Related Issues
Fixes #16863
💥 What does this PR do?
🔄 Types of changes
PR Type
Enhancement
Description
Remove Apache Commons Exec dependency from Java module
Update Maven lockfile with new dependency hashes
Simplify build configuration by removing unused imports
Diagram Walkthrough
File Walkthrough
MODULE.bazel
Remove commons-exec Maven dependencyMODULE.bazel
org.apache.commons:commons-exec:1.6.0dependency declarationBUILD.bazel
Remove commons-exec dependency from buildjava/src/org/openqa/selenium/os/BUILD.bazel
load("@rules_jvm_external//:defs.bzl", "artifact")importstatement
artifact("org.apache.commons:commons-exec")from deps listmaven_install.json
Update Maven lockfile with new dependency hashesjava/maven_install.json
__INPUT_ARTIFACTS_HASHfrom -1443520336 to -1221745853__RESOLVED_ARTIFACTS_HASHfrom 870861529 to -267267215org.apache.commons:commons-execfrom version 1.6.0 to 1.4.0