Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 30 additions & 18 deletions java/src/org/openqa/selenium/json/JsonInput.java
Original file line number Diff line number Diff line change
Expand Up @@ -220,31 +220,43 @@ public String nextName() {
*/
public Number nextNumber() {
expect(JsonType.NUMBER);
boolean decimal = false;
StringBuilder builder = new StringBuilder();
// We know it's safe to use a do/while loop since the first character was a number
boolean fractionalPart = false;
boolean read = true;
do {
char read = input.peek();
if (Character.isDigit(read)
|| read == '+'
|| read == '-'
|| read == 'e'
|| read == 'E'
|| read == '.') {
builder.append(input.read());
} else {
break;
switch (input.peek()) {
case '-':
case '+':
case '0':
case '1':
case '2':
case '3':
case '4':
case '5':
case '6':
case '7':
case '8':
case '9':
builder.append(input.read());
break;
case '.':
case 'e':
case 'E':
decimal = true;
builder.append(input.read());
break;
default:
read = false;
}

fractionalPart |= (read == '.');
} while (true);
} while (read);

try {
Number number = new BigDecimal(builder.toString());
if (fractionalPart) {
return number.doubleValue();
if (!decimal) {
return Long.valueOf(builder.toString());
}
return number.longValue();

return new BigDecimal(builder.toString()).doubleValue();
} catch (NumberFormatException e) {
throw new JsonException("Unable to parse to a number: " + builder + ". " + input);
}
Expand Down
4 changes: 4 additions & 0 deletions java/test/org/openqa/selenium/json/JsonTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ void canReadANumber() {
assertThat((Number) new Json().toType("42", Number.class)).isEqualTo(42L);
assertThat((Integer) new Json().toType("42", Integer.class)).isEqualTo(42);
assertThat((Double) new Json().toType("42", Double.class)).isEqualTo(42.0);
assertThat((Double) new Json().toType("4.2e+1", Double.class)).isEqualTo(42.0);
assertThat((Double) new Json().toType("42e+1", Double.class)).isEqualTo(420.0);
assertThat((Double) new Json().toType("42e-1", Double.class)).isEqualTo(4.2);
assertThat((Double) new Json().toType("4.2e-1", Double.class)).isEqualTo(0.42);
}

@Test
Expand Down