Skip to content

Conversation

@krmahadevan
Copy link
Contributor

Adding documentation that explains how to specify
a directory from which tests can now download files that were downloaded by them on the node.

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Adding documentation that explains how to specify
a directory from which tests can now download files that were downloaded by them on the node.

Description

Adding documentation that explains how to specify
a directory from which tests can now download files that were downloaded by them on the node.

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/63a0aeed81ddcc11f0a44cdb
😎 Deploy Preview https://deploy-preview-1262--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@krmahadevan
Copy link
Contributor Author

This is the documentation for the new feature that was added via PR SeleniumHQ/selenium#11277

ping @diemol

@diemol diemol force-pushed the docs_download_file_to_node branch from 21eeb7f to c95a45a Compare December 13, 2022 10:10
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for raising this PR, @krmahadevan. I left a couple of comments.

@krmahadevan krmahadevan force-pushed the docs_download_file_to_node branch from c95a45a to 68af97b Compare December 15, 2022 03:10
@krmahadevan krmahadevan requested a review from diemol December 15, 2022 10:05
Adding documentation that explains how to specify
a directory from which tests can now download files
that were downloaded by them on the node.
@diemol diemol force-pushed the docs_download_file_to_node branch from 68af97b to a77bc7e Compare December 19, 2022 18:31
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge this as it is and will tweak a couple of things before publishing.

Thank you, @krmahadevan!

@diemol diemol merged commit fd8a67f into SeleniumHQ:trunk Dec 19, 2022
@krmahadevan krmahadevan deleted the docs_download_file_to_node branch December 20, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants