Skip to content

Conversation

@shbenzer
Copy link
Contributor

@shbenzer shbenzer commented Oct 12, 2024

User description

Seems the PrintOptions page's example were incorrectly lined

Description

updated example line references

Motivation and Context

make examples more accurate / readable

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Updated Java code example line references across multiple language documentation files.
  • Ensured the accuracy of example line numbers for better readability and understanding.

Changes walkthrough 📝

Relevant files
Documentation
print_page.en.md
Correct Java example line references in English documentation

website_and_docs/content/documentation/webdriver/interactions/print_page.en.md

  • Updated line references in Java code examples.
  • Corrected example line numbers for accuracy.
  • +8/-8     
    print_page.ja.md
    Correct Java example line references in Japanese documentation

    website_and_docs/content/documentation/webdriver/interactions/print_page.ja.md

  • Updated line references in Java code examples.
  • Corrected example line numbers for accuracy.
  • +8/-8     
    print_page.pt-br.md
    Correct Java example line references in Portuguese documentation

    website_and_docs/content/documentation/webdriver/interactions/print_page.pt-br.md

  • Updated line references in Java code examples.
  • Corrected example line numbers for accuracy.
  • +8/-8     
    print_page.zh-cn.md
    Correct Java example line references in Chinese documentation

    website_and_docs/content/documentation/webdriver/interactions/print_page.zh-cn.md

  • Updated line references in Java code examples.
  • Corrected example line numbers for accuracy.
  • +8/-8     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @netlify
    Copy link

    netlify bot commented Oct 12, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 0a287d3

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 1 labels Oct 12, 2024
    @qodo-merge-pro
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Documentation Consistency
    Ensure that the updated line references in the Java code examples are consistent across all language versions of the documentation.

    @qodo-merge-pro
    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @shbenzer !

    @harsha509 harsha509 merged commit 3489b8e into SeleniumHQ:trunk Oct 12, 2024
    3 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    documentation Improvements or additions to documentation Review effort [1-5]: 1

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants