-
-
Couldn't load subscription status.
- Fork 1.5k
[dotnet] Add page print example #2057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍(Review updated until commit 2c2d39b)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 2c2d39b
Previous suggestionsSuggestions up to commit b09c5f0
|
b09c5f0 to
2c2d39b
Compare
|
Persistent review updated to latest commit 2c2d39b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi @harsha509 ! Thank you for the review. Feedback has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @RenderMichael !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @RenderMichael !
* [.net] Add page print example * PR feedback --------- Co-authored-by: Sri Harsha <[email protected]> 188a509
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Adds an example for print page command in C#. I would add the recently-release BiDi version like Java has, but that surface area is not stable yet iirc.
Motivation and Context
Extra example
Types of changes
Checklist
PR Type
enhancement, documentation
Description
PrintWithPrintsPageTestto demonstrate printing a webpage using Selenium.Changes walkthrough 📝
PrintOptionsTest.cs
Add C# test for printing a webpage using Seleniumexamples/dotnet/SeleniumDocs/Interactions/PrintOptionsTest.cs
PrintWithPrintsPageTest.PrintOptionsandPrintDocumentto print a page.print_page.en.md
Update English documentation with C# print examplewebsite_and_docs/content/documentation/webdriver/interactions/print_page.en.md
print_page.ja.md
Update Japanese documentation with C# print examplewebsite_and_docs/content/documentation/webdriver/interactions/print_page.ja.md
print_page.pt-br.md
Update Portuguese documentation with C# print examplewebsite_and_docs/content/documentation/webdriver/interactions/print_page.pt-br.md
print_page.zh-cn.md
Update Chinese documentation with C# print examplewebsite_and_docs/content/documentation/webdriver/interactions/print_page.zh-cn.md