- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.5k
docs: improve consistency and readability of the guide #2168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ✅ Deploy Preview for selenium-dev ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| PR Reviewer Guide 🔍Here are some key observations to aid the review process: 
 | 
| PR Code Suggestions ✨Explore these optional code suggestions: 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @kathyrollo ,
Thank you for the PR.
Could you please add/update similar changes in other translated pages too( pt-br.md,
zh-cn.md, ja.md), which are other than in en(english) ?
Thanks,
Sri
| Cc: @diemol Hi @harsha509 , sorry it took a bit. I have updated the relevant files. Thanks for reviewing, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* docs: improve consistency and readability of the guide * docs: update all relevant page_object_models.*.md --------- Co-authored-by: Sri Harsha <[email protected]> Co-authored-by: Diego Molina <[email protected]> [deploy site] 708f32f
User description
Hi @diemol , this is a refinement of my previous contributions for Page Component Objects (#1387, #1394).
Description
Motivation and Context
Types of changes
Checklist
PR Type
Documentation
Description
Improved consistency and terminology in the Page Object Model guide.
Added emphasis on the relationship between Page Objects and Page Component Objects.
Enhanced error messages for better clarity during test failures.
Refined examples and explanations for better readability and understanding.
Changes walkthrough 📝
page_object_models.en.md
Refined Page Object Model guide for clarity and consistencywebsite_and_docs/content/documentation/test_practices/encouraged/page_object_models.en.md
with Page Objects.
understanding.