Skip to content

Conversation

@titusfortner
Copy link
Member

@titusfortner titusfortner commented Mar 6, 2025

User description

I keep forgetting to add the deploy site comment, can't we just also do it from GitHub actions manually?


PR Type

enhancement, configuration changes


Description

  • Added manual trigger support for deployment via GitHub Actions.

  • Updated deployment condition to include workflow_dispatch events.


Changes walkthrough 📝

Relevant files
Configuration changes
deploy.yml
Add manual deployment trigger to workflow                               

.github/workflows/deploy.yml

  • Added workflow_dispatch to GitHub Actions triggers.
  • Modified deployment condition to check for manual trigger events.
  • +2/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @titusfortner titusfortner requested a review from diemol March 6, 2025 01:28
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Mar 6, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Mar 6, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Clarify deployment condition logic

    The current condition will always evaluate to true when manually triggered. The
    logical OR with github.event_name == 'workflow_dispatch' makes the commit
    message check redundant for manual triggers. Consider restructuring the
    condition to be more explicit about when deployments should occur.

    .github/workflows/deploy.yml [11]

    -if: contains(toJson(github.event.commits), '[deploy site]') == true || github.event_name == 'workflow_dispatch'
    +if: (github.event_name == 'push' && contains(toJson(github.event.commits), '[deploy site]')) || github.event_name == 'workflow_dispatch'
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    __

    Why: The suggestion improves the condition's clarity by explicitly checking the event type before evaluating commit messages. This prevents potential confusion and makes the intent clearer, especially since commit messages don't exist for manual workflow triggers.

    Medium
    • More

    @netlify
    Copy link

    netlify bot commented Mar 6, 2025

    Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit 4d95763
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/67c8fa2f7a23dd00080f992a
    😎 Deploy Preview https://deploy-preview-2211--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @diemol diemol merged commit 1b5e20e into trunk Mar 6, 2025
    6 checks passed
    @diemol diemol deleted the dispatch-deploy branch March 6, 2025 09:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants