You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
changed links to open in new window/tab
Description
changed links to open in new window/tab
Motivation and Context
changed links to open in new window/tab
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns
Tabnabbing vulnerability: Links with target="_blank" without rel="noopener noreferrer" can allow the opened page to access the original page's window object, potentially leading to tabnabbing attacks where malicious sites could redirect the original page to a phishing site.
External links with target="_blank" should include rel="noopener noreferrer" for security reasons to prevent the new page from accessing the window.opener property and potential tabnabbing attacks.
Add rel="noopener noreferrer" attribute for security when using target="_blank". This prevents the new page from accessing the original window object and protects against potential security vulnerabilities.
Why: The suggestion correctly points out a security best practice by adding rel="noopener noreferrer" to a link with target="_blank", which mitigates potential tabnabbing vulnerabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
changed links to open in new window/tab
Description
changed links to open in new window/tab
Motivation and Context
changed links to open in new window/tab
Types of changes
Checklist
PR Type
Enhancement
Description
Added
target="_blank"attribute to external linksModified conference and archive links to open in new tabs
Changes diagram
Changes walkthrough 📝
_index.html
Add target="_blank" to external linkswebsite_and_docs/content/events/_index.html
target="_blank"attribute to Selenium Conference linktarget="_blank"attribute to conference archive link